Changeset 145d4e2e in mainline

Timestamp:

2024-07-22T20:45:12Z (3 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master

Children:

04e520e

Parents:

48b8928

Message:

Add doxygen group definition and minimal unit tests to libata

Location:

uspace

Files:

• drv/block/isa-ide/isa-ide.c (modified) (1 diff)
• drv/block/pci-ide/pci-ide.c (modified) (1 diff)
• lib/ata/doc/doxygroups.h (added)
• lib/ata/meson.build (modified) (1 diff)
• lib/ata/src/ata.c (modified) (3 diffs)
• lib/ata/test/ata.c (added)
• lib/ata/test/main.c (added)

uspace/drv/block/isa-ide/isa-ide.c

@@ -163 +163 @@
         return EOK;
 error:
+        if (chan->channel != NULL) {
+                (void) ata_channel_destroy(chan->channel);
+                chan->channel = NULL;
+        }
         if (irq_inited)
                 isa_ide_fini_irq(chan);

uspace/drv/block/pci-ide/pci-ide.c

@@ -294 +294 @@
         return EOK;
 error:
+        if (chan->channel != NULL) {
+                (void) ata_channel_destroy(chan->channel);
+                chan->channel = NULL;
+        }
         if (buffer != NULL)
                 dmamem_unmap_anonymous(buffer);

uspace/lib/ata/meson.build

@@ -31 +31 @@
         'src/ata.c'
 )
+
+test_src = files(
+        'test/ata.c',
+        'test/main.c'
+)

uspace/lib/ata/src/ata.c

@@ -151 +151 @@
 {
         ata_channel_t *chan;
+        int i;
 
         chan = calloc(1, sizeof(ata_channel_t));
@@ -162 +163 @@
         fibril_mutex_initialize(&chan->irq_lock);
         fibril_condvar_initialize(&chan->irq_cv);
+
+        for (i = 0; i < MAX_DEVICES; i++)
+                chan->device[i].chan = chan;
 
         *rchan = chan;
@@ -493 +497 @@
         unsigned i;
 
-        d->chan = chan;
         d->device_id = device_id;
         d->present = false;