Changeset 1871118 in mainline for kernel/generic/src/sysinfo/stats.c

Timestamp:

2023-02-10T22:59:11Z (21 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

11d2c983

Parents:

daadfa6

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:53:12)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-02-10 22:59:11)

Message:

Make thread_t reference counted

This simplifies interaction between various locks and thread
lifespan, which simplifies things. For example, threads_lock can
now simply be a mutex protecting the global it was made for, and
nothing more.

File:

• kernel/generic/src/sysinfo/stats.c (modified) (4 diffs)

kernel/generic/src/sysinfo/stats.c

@@ -332 +332 @@
     bool dry_run, void *data)
 {
-        /* Messing with threads structures, avoid deadlock */
+        /* Messing with threads structures */
         irq_spinlock_lock(&threads_lock, true);
 
@@ -597 +597 @@
                 return ret;
 
-        /* Messing with threads structures, avoid deadlock */
+        /* Messing with threads structures */
         irq_spinlock_lock(&threads_lock, true);
 
@@ -627 +627 @@
                 ret.data.size = sizeof(stats_thread_t);
 
-                /* Hand-over-hand locking */
-                irq_spinlock_exchange(&threads_lock, &thread->lock);
-
+                /*
+                 * Replaced hand-over-hand locking with regular nested sections
+                 * to avoid weak reference leak issues.
+                 */
+                irq_spinlock_lock(&thread->lock, false);
                 produce_stats_thread(thread, stats_thread);
-
-                irq_spinlock_unlock(&thread->lock, true);
+                irq_spinlock_unlock(&thread->lock, false);
+
+                irq_spinlock_unlock(&threads_lock, true);
         }
 
@@ -847 +850 @@
 void kload(void *arg)
 {
-        thread_detach(THREAD);
-
         while (true) {
                 size_t ready = atomic_load(&nrdy);