Changeset b7fd2a0 in mainline for uspace/srv/net/udp/service.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/udp/service.c (modified) (14 diffs)

uspace/srv/net/udp/service.c

@@ -70 +70 @@
  * @return EOK on success, ENOMEM if out of memory
  */
-static int udp_cassoc_queue_msg(udp_cassoc_t *cassoc, inet_ep2_t *epp,
+static errno_t udp_cassoc_queue_msg(udp_cassoc_t *cassoc, inet_ep2_t *epp,
     udp_msg_t *msg)
 {
@@ -123 +123 @@
  * @return EOK on soccess, ENOMEM if out of memory
  */
-static int udp_cassoc_create(udp_client_t *client, udp_assoc_t *assoc,
+static errno_t udp_cassoc_create(udp_client_t *client, udp_assoc_t *assoc,
     udp_cassoc_t **rcassoc)
 {
@@ -168 +168 @@
  *         is found.
  */
-static int udp_cassoc_get(udp_client_t *client, sysarg_t id,
+static errno_t udp_cassoc_get(udp_client_t *client, sysarg_t id,
     udp_cassoc_t **rcassoc)
 {
@@ -207 +207 @@
  * @return EOK on success or an error code
  */
-static int udp_assoc_create_impl(udp_client_t *client, inet_ep2_t *epp,
+static errno_t udp_assoc_create_impl(udp_client_t *client, inet_ep2_t *epp,
     sysarg_t *rassoc_id)
 {
         udp_assoc_t *assoc;
         udp_cassoc_t *cassoc;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_create_impl");
@@ -252 +252 @@
  * @return EOK on success, ENOENT if no such association is found
  */
-static int udp_assoc_destroy_impl(udp_client_t *client, sysarg_t assoc_id)
+static errno_t udp_assoc_destroy_impl(udp_client_t *client, sysarg_t assoc_id)
 {
         udp_cassoc_t *cassoc;
-        int rc;
+        errno_t rc;
 
         rc = udp_cassoc_get(client, assoc_id, &cassoc);
@@ -278 +278 @@
  * @return EOK on success, ENOENT if no such association is found
  */
-static int udp_assoc_set_nolocal_impl(udp_client_t *client, sysarg_t assoc_id)
+static errno_t udp_assoc_set_nolocal_impl(udp_client_t *client, sysarg_t assoc_id)
 {
         udp_cassoc_t *cassoc;
-        int rc;
+        errno_t rc;
 
         rc = udp_cassoc_get(client, assoc_id, &cassoc);
@@ -307 +307 @@
  * @return EOK on success or an error code
  */
-static int udp_assoc_send_msg_impl(udp_client_t *client, sysarg_t assoc_id,
+static errno_t udp_assoc_send_msg_impl(udp_client_t *client, sysarg_t assoc_id,
     inet_ep_t *dest, void *data, size_t size)
 {
         udp_msg_t msg;
         udp_cassoc_t *cassoc;
-        int rc;
+        errno_t rc;
 
         rc = udp_cassoc_get(client, assoc_id, &cassoc);
@@ -365 +365 @@
         inet_ep2_t epp;
         sysarg_t assoc_id;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_create_srv()");
@@ -409 +409 @@
 {
         sysarg_t assoc_id;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_destroy_srv()");
@@ -430 +430 @@
 {
         sysarg_t assoc_id;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_NOTE, "udp_assoc_set_nolocal_srv()");
@@ -455 +455 @@
         sysarg_t assoc_id;
         void *data;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_assoc_send_msg_srv()");
@@ -552 +552 @@
         udp_crcv_queue_entry_t *enext;
         sysarg_t assoc_id;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_rmsg_info_srv()");
@@ -601 +601 @@
         size_t size;
         size_t off;
-        int rc;
+        errno_t rc;
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "udp_rmsg_read_srv()");
@@ -752 +752 @@
  * @return EOK on success or an error code.
  */
-int udp_service_init(void)
-{
-        int rc;
+errno_t udp_service_init(void)
+{
+        errno_t rc;
         service_id_t sid;