Changeset 00aece0 in mainline for uspace/srv/vfs/vfs_ops.c

Timestamp:

2012-02-18T16:47:38Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4449c6c

Parents:

bd5f3b7 (diff), f943dd3 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

File:

• uspace/srv/vfs/vfs_ops.c (modified) (22 diffs)

uspace/srv/vfs/vfs_ops.c

@@ -52 +52 @@
 #include <assert.h>
 #include <vfs/canonify.h>
+#include <vfs/vfs_mtab.h>
+
+FIBRIL_MUTEX_INITIALIZE(mtab_list_lock);
+LIST_INITIALIZE(mtab_list);
+static size_t mtab_size = 0;
 
 /* Forward declarations of static functions. */
@@ -68 +73 @@
 };
 
-static void vfs_mount_internal(ipc_callid_t rid, service_id_t service_id,
+static int vfs_mount_internal(ipc_callid_t rid, service_id_t service_id,
     fs_handle_t fs_handle, char *mp, char *opts)
 {
@@ -91 +96 @@
                         fibril_rwlock_write_unlock(&namespace_rwlock);
                         async_answer_0(rid, EBUSY);
-                        return;
+                        return EBUSY;
                 }
                 
@@ -99 +104 @@
                         fibril_rwlock_write_unlock(&namespace_rwlock);
                         async_answer_0(rid, rc);
-                        return;
+                        return rc;
                 }
                 
@@ -106 +111 @@
                         fibril_rwlock_write_unlock(&namespace_rwlock);
                         async_answer_0(rid, ENOMEM);
-                        return;
+                        return ENOMEM;
                 }
                 
@@ -135 +140 @@
                                 fibril_rwlock_write_unlock(&namespace_rwlock);
                                 async_answer_0(rid, rc);
-                                return;
+                                return rc;
                         }
                         async_wait_for(msg, &rc);
@@ -142 +147 @@
                                 fibril_rwlock_write_unlock(&namespace_rwlock);
                                 async_answer_0(rid, rc);
-                                return;
+                                return rc;
                         }
 
                         rindex = (fs_index_t) IPC_GET_ARG1(answer);
-                        rsize = (aoff64_t) MERGE_LOUP32(IPC_GET_ARG2(answer), IPC_GET_ARG3(answer));
+                        rsize = (aoff64_t) MERGE_LOUP32(IPC_GET_ARG2(answer),
+                            IPC_GET_ARG3(answer));
                         rlnkcnt = (unsigned) IPC_GET_ARG4(answer);
                         
@@ -165 +171 @@
                         fibril_rwlock_write_unlock(&namespace_rwlock);
                         async_answer_0(rid, rc);
-                        return;
+                        return rc;
                 } else {
                         /*
@@ -173 +179 @@
                         fibril_rwlock_write_unlock(&namespace_rwlock);
                         async_answer_0(rid, ENOENT);
-                        return;
+                        return ENOENT;
                 }
         }
@@ -206 +212 @@
                 async_answer_0(rid, rc);
                 fibril_rwlock_write_unlock(&namespace_rwlock);
-                return;
+                return rc;
         }
         
@@ -221 +227 @@
                 fibril_rwlock_write_unlock(&namespace_rwlock);
                 async_answer_0(rid, rc);
-                return;
-        }
-        
+                return rc;
+        }
+        
+        /*
+         * Wait for the answer before releasing the exchange to avoid deadlock
+         * in case the answer depends on further calls to the same file system.
+         * Think of a case when mounting a FS on a file_bd backed by a file on
+         * the same FS. 
+         */
+        async_wait_for(msg, &rc);
         vfs_exchange_release(exch);
-        async_wait_for(msg, &rc);
         
         if (rc == EOK) {
@@ -251 +263 @@
         async_answer_0(rid, rc);
         fibril_rwlock_write_unlock(&namespace_rwlock);
+        return rc;
 }
 
@@ -270 +283 @@
         
         /*
-         * For now, don't make use of ARG3, but it can be used to
-         * carry mount options in the future.
-         */
-        
+         * Instance number is passed as ARG3.
+         */
+        unsigned int instance = IPC_GET_ARG3(*request);
+
         /* We want the client to send us the mount point. */
         char *mp;
@@ -329 +342 @@
         fs_handle_t fs_handle;
 recheck:
-        fs_handle = fs_name_to_handle(fs_name, false);
+        fs_handle = fs_name_to_handle(instance, fs_name, false);
         if (!fs_handle) {
                 if (flags & IPC_FLAG_BLOCKING) {
@@ -345 +358 @@
         }
         fibril_mutex_unlock(&fs_list_lock);
-        
-        /* Acknowledge that we know fs_name. */
-        async_answer_0(callid, EOK);
-        
+
+        /* Add the filesystem info to the list of mounted filesystems */
+        mtab_ent_t *mtab_ent = malloc(sizeof(mtab_ent_t));
+        if (!mtab_ent) {
+                async_answer_0(callid, ENOMEM);
+                async_answer_0(rid, ENOMEM);
+                free(mp);
+                free(fs_name);
+                free(opts);
+                return;
+        }
+
         /* Do the mount */
-        vfs_mount_internal(rid, service_id, fs_handle, mp, opts);
+        rc = vfs_mount_internal(rid, service_id, fs_handle, mp, opts);
+        if (rc != EOK) {
+                async_answer_0(callid, ENOTSUP);
+                async_answer_0(rid, ENOTSUP);
+                free(mtab_ent);
+                free(mp);
+                free(opts);
+                free(fs_name);
+                return;
+        }
+
+        /* Add the filesystem info to the list of mounted filesystems */
+
+        str_cpy(mtab_ent->mp, MAX_PATH_LEN, mp);
+        str_cpy(mtab_ent->fs_name, FS_NAME_MAXLEN, fs_name);
+        str_cpy(mtab_ent->opts, MAX_MNTOPTS_LEN, opts);
+        mtab_ent->instance = instance;
+        mtab_ent->service_id = service_id;
+
+        link_initialize(&mtab_ent->link);
+
+        fibril_mutex_lock(&mtab_list_lock);
+        list_append(&mtab_ent->link, &mtab_list);
+        mtab_size++;
+        fibril_mutex_unlock(&mtab_list_lock);
+
         free(mp);
         free(fs_name);
         free(opts);
+
+        /* Acknowledge that we know fs_name. */
+        async_answer_0(callid, EOK);
 }
 
@@ -426 +475 @@
                  */
                 
-                free(mp);
-                
                 exch = vfs_exchange_grab(mr_node->fs_handle);
                 rc = async_req_1_0(exch, VFS_OUT_UNMOUNTED,
@@ -435 +482 @@
                 if (rc != EOK) {
                         fibril_rwlock_write_unlock(&namespace_rwlock);
+                        free(mp);
                         vfs_node_put(mr_node);
                         async_answer_0(rid, rc);
@@ -452 +500 @@
                 
                 rc = vfs_lookup_internal(mp, L_MP, &mp_res, NULL);
-                free(mp);
                 if (rc != EOK) {
                         fibril_rwlock_write_unlock(&namespace_rwlock);
+                        free(mp);
                         vfs_node_put(mr_node);
                         async_answer_0(rid, rc);
@@ -463 +511 @@
                 if (!mp_node) {
                         fibril_rwlock_write_unlock(&namespace_rwlock);
+                        free(mp);
                         vfs_node_put(mr_node);
                         async_answer_0(rid, ENOMEM);
@@ -475 +524 @@
                 if (rc != EOK) {
                         fibril_rwlock_write_unlock(&namespace_rwlock);
+                        free(mp);
                         vfs_node_put(mp_node);
                         vfs_node_put(mr_node);
@@ -492 +542 @@
          */
         vfs_node_forget(mr_node);
-        
         fibril_rwlock_write_unlock(&namespace_rwlock);
+
+        fibril_mutex_lock(&mtab_list_lock);
+
+        int found = 0;
+
+        list_foreach(mtab_list, cur) {
+                mtab_ent_t *mtab_ent = list_get_instance(cur, mtab_ent_t,
+                    link);
+
+                if (str_cmp(mtab_ent->mp, mp) == 0) {
+                        list_remove(&mtab_ent->link);
+                        mtab_size--;
+                        free(mtab_ent);
+                        found = 1;
+                        break;
+                }
+        }
+        assert(found);
+        fibril_mutex_unlock(&mtab_list_lock);
+
+        free(mp);
+
         async_answer_0(rid, EOK);
 }
@@ -1282 +1353 @@
 }
 
+void vfs_get_mtab(ipc_callid_t rid, ipc_call_t *request)
+{
+        ipc_callid_t callid;
+        ipc_call_t data;
+        sysarg_t rc = EOK;
+        size_t len;
+
+        fibril_mutex_lock(&mtab_list_lock);
+
+        /* Send to the caller the number of mounted filesystems */
+        callid = async_get_call(&data);
+        if (IPC_GET_IMETHOD(data) != VFS_IN_PING) {
+                rc = ENOTSUP;
+                async_answer_0(callid, rc);
+                goto exit;
+        }
+        async_answer_1(callid, EOK, mtab_size);
+
+        list_foreach(mtab_list, cur) {
+                mtab_ent_t *mtab_ent = list_get_instance(cur, mtab_ent_t,
+                    link);
+
+                rc = ENOTSUP;
+
+                if (!async_data_read_receive(&callid, &len)) {
+                        async_answer_0(callid, rc);
+                        goto exit;
+                }
+
+                (void) async_data_read_finalize(callid, mtab_ent->mp,
+                    str_size(mtab_ent->mp));
+
+                if (!async_data_read_receive(&callid, &len)) {
+                        async_answer_0(callid, rc);
+                        goto exit;
+                }
+
+                (void) async_data_read_finalize(callid, mtab_ent->opts,
+                    str_size(mtab_ent->opts));
+
+                if (!async_data_read_receive(&callid, &len)) {
+                        async_answer_0(callid, rc);
+                        goto exit;
+                }
+
+                (void) async_data_read_finalize(callid, mtab_ent->fs_name,
+                    str_size(mtab_ent->fs_name));
+
+                callid = async_get_call(&data);
+
+                if (IPC_GET_IMETHOD(data) != VFS_IN_PING) {
+                        async_answer_0(callid, rc);
+                        goto exit;
+                }
+
+                rc = EOK;
+                async_answer_2(callid, rc, mtab_ent->instance,
+                    mtab_ent->service_id);
+        }
+
+exit:
+        fibril_mutex_unlock(&mtab_list_lock);
+        async_answer_0(rid, rc);
+}
+
 /**
  * @}