Changeset 01e68af in mainline


Ignore:
Timestamp:
2019-08-17T13:43:48Z (5 years ago)
Author:
Matthieu Riolo <matthieu.riolo@…>
Children:
95d4280a
Parents:
24b30e1
git-author:
Michal Koutný <xm.koutny+hos@…> (2015-12-04 14:31:40)
git-committer:
Matthieu Riolo <matthieu.riolo@…> (2019-08-17 13:43:48)
Message:

sysman: Remove stale TODOs

Location:
uspace
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • uspace/lib/sysman/src/sysman.c

    r24b30e1 r01e68af  
    3535async_exch_t *sysman_exchange_begin(sysman_interface_t iface)
    3636{
    37         // TODO need special session for each iface!
    3837        if (sysman_sess[iface] == NULL) {
    3938                // TODO serialize vs parallel

  • uspace/srv/sysman/connection_broker.c

    r24b30e1 r01e68af  
    4040        sysman_log(LVL_DEBUG2, "%s", __func__);
    4141        async_answer_0(iid, EOK);
    42         /* TODO implement
    43          *  What exactly? Similar behavior that has locsrv with servers,
    44          *  so that subsequent calls can be assigned to broker. Still that
    45          *  makes sense only when brokers will somehow scope unit/exposee
     42        /*
     43         *  What exactly do here? Similar behavior that has locsrv with
     44         *  servers, so that subsequent calls can be assigned to broker. Still
     45         *  that makes sense only when brokers will somehow scope unit/exposee
    4646         *  names. Why I wanted this registration?
    4747         */

  • uspace/srv/sysman/job.c

    r24b30e1 r01e68af  
    217217                break;
    218218        default:
    219                 // TODO implement other states?
    220219                assert(false);
    221220        }

  • uspace/srv/sysman/job_queue.c

    r24b30e1 r01e68af  
    261261 * be queued after this job_queue_process call.
    262262 *
    263  * TODO Write down rules from where this function can be called, to avoid stack
    264  *      overflow.
    265263 */
    266264void job_queue_process(void)

  • uspace/srv/sysman/unit.c

    r24b30e1 r01e68af  
    9898        UNIT_VMT(unit)->destroy(unit);
    9999        /* TODO:
    100          *      edges,
    101          *      check it's not an active unit,
    102          *      other resources to come
     100         *      edges
    103101         */
    104102        free(unit->name);

  • uspace/srv/sysman/units/unit_mnt.c

    r24b30e1 r01e68af  
    196196
    197197       
    198         // TODO think about unit's lifecycle (is STOPPED only acceptable?)
    199198        assert(unit->state == STATE_STOPPED);
    200199
    … …  
    237236
    238237       
    239         // TODO think about unit's lifecycle (is STOPPED only acceptable?)
    240238        // note: we should never hit STATE_STARTING, since it'd mean there are
    241239        //       two jobs running at once (unless job cancellation is implemented)

  • uspace/srv/sysman/units/unit_svc.c

    r24b30e1 r01e68af  
    8282
    8383       
    84         // TODO think about unit's lifecycle (is STOPPED only acceptable?)
    8584        assert(unit->state == STATE_STOPPED);
    8685
    … …  
    118117
    119118       
    120         // TODO think about unit's lifecycle (is STOPPED only acceptable?)
    121119        // note: May change when job cancellation is possible.
    122120        assert(unit->state == STATE_STARTED);

  • uspace/srv/sysman/units/unit_tgt.c

    r24b30e1 r01e68af  
    8080static void unit_tgt_fail(unit_t *unit)
    8181{
    82         // TODO define semantics and implement
    8382}
    8483
Note: See TracChangeset for help on using the changeset viewer.