Changes in uspace/srv/net/ethip/ethip_nic.c [83781a22:02a09ed] in mainline

File:

• uspace/srv/net/ethip/ethip_nic.c (modified) (13 diffs)

uspace/srv/net/ethip/ethip_nic.c

@@ -45 +45 @@
 #include <device/nic.h>
 #include <stdlib.h>
-#include <net/socket_codes.h>
-#include <mem.h>
+
 #include "ethip.h"
 #include "ethip_nic.h"
@@ -84 +83 @@
                 already_known = false;
 
-                list_foreach(ethip_nic_list, link) {
-                        ethip_nic_t *nic = list_get_instance(link,
-                            ethip_nic_t, link);
+                list_foreach(ethip_nic_list, nic_link) {
+                        ethip_nic_t *nic = list_get_instance(nic_link,
+                            ethip_nic_t, nic_list);
                         if (nic->svc_id == svcs[i]) {
                                 already_known = true;
@@ -109 +108 @@
 {
         ethip_nic_t *nic = calloc(1, sizeof(ethip_nic_t));
+
         if (nic == NULL) {
                 log_msg(LOG_DEFAULT, LVL_ERROR, "Failed allocating NIC structure. "
@@ -114 +114 @@
                 return NULL;
         }
-        
-        link_initialize(&nic->link);
+
+        link_initialize(&nic->nic_list);
         list_initialize(&nic->addr_list);
-        
+
         return nic;
 }
@@ -130 +130 @@
         }
         
-        link_initialize(&laddr->link);
+        link_initialize(&laddr->addr_list);
         laddr->addr = *addr;
         
@@ -140 +140 @@
         if (nic->svc_name != NULL)
                 free(nic->svc_name);
-        
         free(nic);
 }
@@ -181 +180 @@
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "Opened NIC '%s'", nic->svc_name);
-        list_append(&nic->link, &ethip_nic_list);
+        list_append(&nic->nic_list, &ethip_nic_list);
         in_list = true;
 
@@ -210 +209 @@
 error:
         if (in_list)
-                list_remove(&nic->link);
-        
+                list_remove(&nic->nic_list);
         if (nic->sess != NULL)
                 async_hangup(nic->sess);
-        
         ethip_nic_delete(nic);
         return rc;
@@ -315 +312 @@
         list_foreach(ethip_nic_list, link) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_nic_find_by_iplink_sid - element");
-                ethip_nic_t *nic = list_get_instance(link, ethip_nic_t, link);
+                ethip_nic_t *nic = list_get_instance(link, ethip_nic_t,
+                    nic_list);
 
                 if (nic->iplink_sid == iplink_sid) {
@@ -336 +334 @@
 }
 
-/** Setup accepted multicast addresses
- *
- * Currently the set of accepted multicast addresses is
- * determined only based on IPv6 addresses.
- *
- */
-static int ethip_nic_setup_multicast(ethip_nic_t *nic)
-{
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "ethip_nic_setup_multicast()");
-        
-        /* Count the number of multicast addresses */
-        
-        size_t count = 0;
-        
-        list_foreach(nic->addr_list, link) {
-                ethip_link_addr_t *laddr = list_get_instance(link,
-                    ethip_link_addr_t, link);
-                
-                uint16_t af = inet_addr_get(&laddr->addr, NULL, NULL);
-                if (af == AF_INET6)
-                        count++;
-        }
-        
-        if (count == 0)
-                return nic_multicast_set_mode(nic->sess, NIC_MULTICAST_BLOCKED,
-                    NULL, 0);
-        
-        nic_address_t *mac_list = calloc(count, sizeof(nic_address_t));
-        if (mac_list == NULL)
-                return ENOMEM;
-        
-        /* Create the multicast MAC list */
-        
-        size_t i = 0;
-        
-        list_foreach(nic->addr_list, link) {
-                assert(i < count);
-                
-                ethip_link_addr_t *laddr = list_get_instance(link,
-                    ethip_link_addr_t, link);
-                
-                addr128_t v6;
-                uint16_t af = inet_addr_get(&laddr->addr, NULL, &v6);
-                if (af != AF_INET6)
-                        continue;
-                
-                addr48_t mac;
-                addr48_solicited_node(v6, mac);
-                
-                /* Avoid duplicate addresses in the list */
-                
-                bool found = false;
-                
-                for (size_t j = 0; j < i; j++) {
-                        if (addr48_compare(mac_list[j].address, mac)) {
-                                found = true;
-                                break;
-                        }
-                }
-                
-                if (!found) {
-                        addr48(mac, mac_list[i].address);
-                        i++;
-                } else
-                        count--;
-        }
-        
-        /* Setup the multicast MAC list */
-        
-        int rc = nic_multicast_set_mode(nic->sess, NIC_MULTICAST_LIST,
-            mac_list, count);
-        
-        free(mac_list);
-        return rc;
-}
-
 int ethip_nic_addr_add(ethip_nic_t *nic, inet_addr_t *addr)
 {
@@ -420 +342 @@
                 return ENOMEM;
         
-        list_append(&laddr->link, &nic->addr_list);
-        
-        return ethip_nic_setup_multicast(nic);
+        list_append(&laddr->addr_list, &nic->addr_list);
+        return EOK;
 }
 
@@ -433 +354 @@
                 return ENOENT;
         
-        list_remove(&laddr->link);
+        list_remove(&laddr->addr_list);
         ethip_link_addr_delete(laddr);
-        
-        return ethip_nic_setup_multicast(nic);
+        return EOK;
 }
 
@@ -446 +366 @@
         list_foreach(nic->addr_list, link) {
                 ethip_link_addr_t *laddr = list_get_instance(link,
-                    ethip_link_addr_t, link);
+                    ethip_link_addr_t, addr_list);
                 
                 if (inet_addr_compare(addr, &laddr->addr))