Changes in uspace/drv/ohci/root_hub.c [3476be8:05e21ffc] in mainline

File:

• uspace/drv/ohci/root_hub.c (modified) (9 diffs)

uspace/drv/ohci/root_hub.c

@@ -41 +41 @@
 #include "usb/classes/classes.h"
 #include "usb/devdrv.h"
-#include "ohci_regs.h"
-
 #include <usb/request.h>
 #include <usb/classes/hub.h>
@@ -111 +109 @@
  */
 static const uint32_t hub_clear_feature_valid_mask =
-    RHS_OCIC_FLAG |
-    RHS_CLEAR_PORT_POWER;
+    (1 << USB_HUB_FEATURE_C_HUB_LOCAL_POWER) |
+    (1 << USB_HUB_FEATURE_C_HUB_OVER_CURRENT);
 
 /**
@@ -118 +116 @@
  */
 static const uint32_t hub_clear_feature_by_writing_one_mask =
-   RHS_CLEAR_PORT_POWER;
-   // 1 << USB_HUB_FEATURE_C_HUB_LOCAL_POWER;
+    1 << USB_HUB_FEATURE_C_HUB_LOCAL_POWER;
 
 /**
@@ -125 +122 @@
  */
 static const uint32_t hub_set_feature_valid_mask =
-    RHS_LPSC_FLAG |
-    RHS_OCIC_FLAG;
-    //(1 << USB_HUB_FEATURE_C_HUB_OVER_CURRENT) |
-    //(1 << USB_HUB_FEATURE_C_HUB_LOCAL_POWER);
+    (1 << USB_HUB_FEATURE_C_HUB_OVER_CURRENT) |
+    (1 << USB_HUB_FEATURE_C_HUB_LOCAL_POWER);
 
 /**
@@ -134 +129 @@
  */
 static const uint32_t hub_set_feature_direct_mask =
-    RHS_SET_PORT_POWER;
-    //(1 << USB_HUB_FEATURE_C_HUB_OVER_CURRENT);
+    (1 << USB_HUB_FEATURE_C_HUB_OVER_CURRENT);
 
 /**
@@ -141 +135 @@
  */
 static const uint32_t port_set_feature_valid_mask =
-    RHPS_SET_PORT_ENABLE |
-    RHPS_SET_PORT_SUSPEND |
-    RHPS_SET_PORT_RESET |
-    RHPS_SET_PORT_POWER;
+    (1 << USB_HUB_FEATURE_PORT_ENABLE) |
+    (1 << USB_HUB_FEATURE_PORT_SUSPEND) |
+    (1 << USB_HUB_FEATURE_PORT_RESET) |
+    (1 << USB_HUB_FEATURE_PORT_POWER);
 
 /**
@@ -150 +144 @@
  */
 static const uint32_t port_clear_feature_valid_mask =
-    RHPS_CCS_FLAG |
-    RHPS_SET_PORT_SUSPEND |
-    RHPS_POCI_FLAG |
-    RHPS_SET_PORT_POWER |
-    RHPS_CSC_FLAG |
-    RHPS_PESC_FLAG |
-    RHPS_PSSC_FLAG |
-    RHPS_OCIC_FLAG |
-    RHPS_PRSC_FLAG;
-
-/*
-
     (1 << USB_HUB_FEATURE_PORT_CONNECTION) |
     (1 << USB_HUB_FEATURE_PORT_SUSPEND) |
@@ -171 +153 @@
     (1 << USB_HUB_FEATURE_C_PORT_OVER_CURRENT) |
     (1 << USB_HUB_FEATURE_C_PORT_RESET);
- */
 //note that USB_HUB_FEATURE_PORT_POWER bit is translated into
-//USB_HUB_FEATURE_PORT_LOW_SPEED for port set feature request
+//USB_HUB_FEATURE_PORT_LOW_SPEED
 
 /**
  * bitmask with port status changes
  */
-static const uint32_t port_status_change_mask = RHPS_CHANGE_WC_MASK;
-/*    (1 << USB_HUB_FEATURE_C_PORT_CONNECTION) |
+static const uint32_t port_status_change_mask =
+    (1 << USB_HUB_FEATURE_C_PORT_CONNECTION) |
     (1 << USB_HUB_FEATURE_C_PORT_ENABLE) |
     (1 << USB_HUB_FEATURE_C_PORT_OVER_CURRENT) |
     (1 << USB_HUB_FEATURE_C_PORT_RESET) |
     (1 << USB_HUB_FEATURE_C_PORT_SUSPEND);
-*/
+
 
 static int create_serialized_hub_descriptor(rh_t *instance);
@@ -256 +237 @@
                 return ENOMEM;
 
-        usb_log_info("OHCI root hub with %zu ports initialized.\n",
+        usb_log_info("OHCI root hub with %d ports initialized.\n",
             instance->port_count);