Changes in uspace/drv/bus/usb/usbmid/explore.c [9d58539:065064e6] in mainline

File:

• uspace/drv/bus/usb/usbmid/explore.c (modified) (7 diffs)

uspace/drv/bus/usb/usbmid/explore.c

@@ -54 +54 @@
  * @return Interface @p interface_no is already present in the list.
  */
-static bool interface_in_list(const list_t *list, int interface_no)
+static bool interface_in_list(list_t *list, int interface_no)
 {
         list_foreach(*list, l) {
-                usbmid_interface_t *iface = usbmid_interface_from_link(l);
+                usbmid_interface_t *iface
+                    = list_get_instance(l, usbmid_interface_t, link);
                 if (iface->interface_no == interface_no) {
                         return true;
@@ -81 +82 @@
         };
 
-        static const usb_dp_parser_t parser = {
+        usb_dp_parser_t parser = {
                 .nesting = usb_dp_standard_descriptor_nesting
         };
 
         const uint8_t *interface_ptr =
-            usb_dp_get_nested_descriptor(&parser, &data, config_descriptor);
-
-        /* Walk all descriptors nested in the current configuration decriptor;
-         * i.e. all interface descriptors. */
-        for (;interface_ptr != NULL;
-            interface_ptr = usb_dp_get_sibling_descriptor(
-                &parser, &data, config_descriptor, interface_ptr))
-        {
-                /* The second byte is DESCTYPE byte in all desriptors. */
-                if (interface_ptr[1] != USB_DESCTYPE_INTERFACE)
-                        continue;
-
-                const usb_standard_interface_descriptor_t *interface
+            usb_dp_get_nested_descriptor(&parser, &data, data.data);
+        if (interface_ptr == NULL) {
+                return;
+        }
+
+        do {
+                if (interface_ptr[1] != USB_DESCTYPE_INTERFACE) {
+                        goto next_descriptor;
+                }
+
+                usb_standard_interface_descriptor_t *interface
                     = (usb_standard_interface_descriptor_t *) interface_ptr;
 
                 /* Skip alternate interfaces. */
-                if (interface_in_list(list, interface->interface_number)) {
-                        /* TODO: add the alternatives and create match ids
-                         * for them. */
-                        continue;
-                }
-                usbmid_interface_t *iface = malloc(sizeof(usbmid_interface_t));
-                if (iface == NULL) {
-                        //TODO: Do something about that failure.
-                        break;
-                }
-
-                link_initialize(&iface->link);
-                iface->fun = NULL;
-                iface->interface_no = interface->interface_number;
-                iface->interface = interface;
-
-                list_append(&iface->link, list);
-        }
+                if (!interface_in_list(list, interface->interface_number)) {
+                        usbmid_interface_t *iface
+                            = malloc(sizeof(usbmid_interface_t));
+                        if (iface == NULL) {
+                                break;
+                        }
+                        link_initialize(&iface->link);
+                        iface->fun = NULL;
+                        iface->interface_no = interface->interface_number;
+                        iface->interface = interface;
+
+                        list_append(&iface->link, list);
+                }
+
+                /* TODO: add the alternatives and create match ids from them
+                 * as well.
+                 */
+
+next_descriptor:
+                interface_ptr = usb_dp_get_sibling_descriptor(&parser, &data,
+                    data.data, interface_ptr);
+
+        } while (interface_ptr != NULL);
+
 }
 
@@ -134 +139 @@
         int rc;
 
-        unsigned dev_class = dev->descriptors.device.device_class;
+        int dev_class = dev->descriptors.device.device_class;
         if (dev_class != USB_CLASS_USE_INTERFACE) {
                 usb_log_warning(
-                    "Device class: %u (%s), but expected class %u.\n",
-                    dev_class, usb_str_class(dev_class),
-                    USB_CLASS_USE_INTERFACE);
+                    "Device class: %d (%s), but expected class 0.\n",
+                    dev_class, usb_str_class(dev_class));
                 usb_log_error("Not multi interface device, refusing.\n");
                 return false;
         }
 
-        /* Shortcuts to save on typing ;-). */
+        /* Short cuts to save on typing ;-). */
         const void *config_descriptor_raw = dev->descriptors.configuration;
         size_t config_descriptor_size = dev->descriptors.configuration_size;
@@ -159 +163 @@
         }
 
-        /* Create driver soft-state. */
         usb_mid_t *usb_mid = usb_device_data_alloc(dev, sizeof(usb_mid_t));
         if (!usb_mid) {
@@ -166 +169 @@
         }
 
-        /* Create control function. */
+        /* Create control function */
         usb_mid->ctl_fun = ddf_fun_create(dev->ddf_dev, fun_exposed, "ctl");
         if (usb_mid->ctl_fun == NULL) {
@@ -172 +175 @@
                 return false;
         }
+
         usb_mid->ctl_fun->ops = &mid_device_ops;
 
-        /* Bind control function. */
         rc = ddf_fun_bind(usb_mid->ctl_fun);
         if (rc != EOK) {
@@ -189 +192 @@
             &usb_mid->interface_list);
 
-        /* Start child function for every interface. */
         list_foreach(usb_mid->interface_list, link) {
-                usbmid_interface_t *iface = usbmid_interface_from_link(link);
+                usbmid_interface_t *iface = list_get_instance(link,
+                    usbmid_interface_t, link);
 
                 usb_log_info("Creating child for interface %d (%s).\n",
-                    iface->interface_no,
+                    (int) iface->interface_no,
                     usb_str_class(iface->interface->interface_class));