Changeset 075c1eb in mainline for uspace

Timestamp:

2011-05-06T13:09:39Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6c6a95d2, 9350e837

Parents:

310c4df (diff), 3d4aa055 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

OHCI interrupts

Kernel support for accessing memory mapped registers in irq handler(AS switch)

Location:

uspace

Files:

• drv/ehci-hcd/pci.c (modified) (1 diff)
• drv/ohci/hc.c (modified) (4 diffs)
• drv/ohci/hc.h (modified) (2 diffs)
• drv/ohci/ohci.c (modified) (1 diff)
• drv/ohci/ohci_regs.h (modified) (1 diff)
• drv/ohci/pci.c (modified) (1 diff)
• lib/usb/src/host/batch.c (modified) (2 diffs)

uspace/drv/ehci-hcd/pci.c

@@ -186 +186 @@
         CHECK_RET_HANGUP_RETURN(ret, "Failed(%d) to read PCI config space.\n",
             ret);
-        usb_log_info("Register space BAR at %p:%" PRIxn ".\n", (void *) address, value);
+        usb_log_info("Register space BAR at %p:%" PRIxn ".\n",
+            (void *) address, value);
 
         /* clear lower byte, it's not part of the BASE address */

uspace/drv/ohci/hc.c

@@ -45 +45 @@
 #include "hcd_endpoint.h"
 
+#define OHCI_USED_INTERRUPTS \
+    (I_SO | I_WDH | I_UE | I_RHSC)
 static int interrupt_emulator(hc_t *instance);
 static void hc_gain_control(hc_t *instance);
@@ -285 +287 @@
 {
         assert(instance);
-        if ((status & ~IS_SF) == 0) /* ignore sof status */
+        usb_log_debug("OHCI interrupt: %x.\n", status);
+        if ((status & ~I_SF) == 0) /* ignore sof status */
                 return;
-        if (status & IS_RHSC)
+        if (status & I_RHSC)
                 rh_interrupt(&instance->rh);
 
-        usb_log_debug("OHCI interrupt: %x.\n", status);
-
-        if (status & IS_WDH) {
+
+        if (status & I_WDH) {
                 fibril_mutex_lock(&instance->guard);
                 usb_log_debug2("HCCA: %p-%#" PRIx32 " (%p).\n", instance->hcca,
@@ -421 +423 @@
             instance->registers->control);
 
-        /* Disable interrupts */
-        instance->registers->interrupt_disable = I_SF | I_OC;
-        usb_log_debug2("Disabling interrupts: %x.\n",
-            instance->registers->interrupt_disable);
-        instance->registers->interrupt_disable = I_MI;
+        /* Enable interrupts */
+        instance->registers->interrupt_enable = OHCI_USED_INTERRUPTS;
         usb_log_debug2("Enabled interrupts: %x.\n",
             instance->registers->interrupt_enable);
+        instance->registers->interrupt_enable = I_MI;
 
         /* Set periodic start to 90% */
@@ -492 +492 @@
             instance->lists[USB_TRANSFER_INTERRUPT].list_head_pa);
 
+        /* Init interrupt code */
+        instance->interrupt_code.cmds = instance->interrupt_commands;
+        {
+                /* Read status register */
+                instance->interrupt_commands[0].cmd = CMD_MEM_READ_32;
+                instance->interrupt_commands[0].dstarg = 1;
+                instance->interrupt_commands[0].addr =
+                    (void*)&instance->registers->interrupt_status;
+
+                /* Test whether we are the interrupt cause */
+                instance->interrupt_commands[1].cmd = CMD_BTEST;
+                instance->interrupt_commands[1].value =
+                    OHCI_USED_INTERRUPTS;
+                instance->interrupt_commands[1].srcarg = 1;
+                instance->interrupt_commands[1].dstarg = 2;
+
+                /* Predicate cleaning and accepting */
+                instance->interrupt_commands[2].cmd = CMD_PREDICATE;
+                instance->interrupt_commands[2].value = 2;
+                instance->interrupt_commands[2].srcarg = 2;
+
+                /* Write clean status register */
+                instance->interrupt_commands[3].cmd = CMD_MEM_WRITE_A_32;
+                instance->interrupt_commands[3].srcarg = 1;
+                instance->interrupt_commands[3].addr =
+                    (void*)&instance->registers->interrupt_status;
+
+                /* Accept interrupt */
+                instance->interrupt_commands[4].cmd = CMD_ACCEPT;
+
+                instance->interrupt_code.cmdcount = OHCI_NEEDED_IRQ_COMMANDS;
+        }
+
         return EOK;
 }

uspace/drv/ohci/hc.h

@@ -51 +51 @@
 #include "hw_struct/hcca.h"
 
+#define OHCI_NEEDED_IRQ_COMMANDS 5
+
 typedef struct hc {
         ohci_regs_t *registers;
@@ -65 +67 @@
         fid_t interrupt_emulator;
         fibril_mutex_t guard;
+
+        /** Code to be executed in kernel interrupt handler */
+        irq_code_t interrupt_code;
+
+        /** Commands that form interrupt code */
+        irq_cmd_t interrupt_commands[OHCI_NEEDED_IRQ_COMMANDS];
 } hc_t;
 

uspace/drv/ohci/ohci.c

@@ -202 +202 @@
 
         /* It does no harm if we register this on polling */
-        ret = register_interrupt_handler(device, irq, irq_handler, NULL);
+        ret = register_interrupt_handler(device, irq, irq_handler,
+            &instance->hc.interrupt_code);
         CHECK_RET_FINI_RETURN(ret,
             "Failed(%d) to register interrupt handler.\n", ret);

uspace/drv/ohci/ohci_regs.h

@@ -72 +72 @@
 #define CS_SOC_SHIFT (16)
 
+        /** Interupt enable/disable/status,
+         * reads give the same value,
+         * writing causes enable/disable,
+         * status is write-clean (writing 1 clears the bit*/
         volatile uint32_t interrupt_status;
-#define IS_SO   (1 << 0)  /* Scheduling overrun */
-#define IS_WDH  (1 << 1)  /* Write-back done head */
-#define IS_SF   (1 << 2)  /* Start of frame */
-#define IS_RD   (1 << 3)  /* Resume detected */
-#define IS_UE   (1 << 4)  /* Unrecoverable error */
-#define IS_FNO  (1 << 5)  /* Frame number overflow */
-#define IS_RHSC (1 << 6)  /* Root hub status change */
-#define IS_OC   (1 << 30) /* Ownership change */
-
-        /** Interupt enable/disable, reads give the same value, writing causes
-         * enable/disable */
         volatile uint32_t interrupt_enable;
         volatile uint32_t interrupt_disable;

uspace/drv/ohci/pci.c

@@ -146 +146 @@
 int pci_enable_interrupts(ddf_dev_t *device)
 {
-        return ENOTSUP;
         int parent_phone =
             devman_parent_device_connect(device->handle, IPC_FLAG_BLOCKING);

uspace/lib/usb/src/host/batch.c

@@ -128 +128 @@
         memcpy(instance->buffer, instance->data_buffer, instance->buffer_size);
 
-        usb_log_debug("Batch %p done (T%d.%d, %s %s in, %zuB): %s (%d).\n",
+        usb_log_debug("Batch(%p) done (T%d.%d, %s %s in, %zuB): %s (%d).\n",
             instance, instance->ep->address, instance->ep->endpoint,
             usb_str_speed(instance->ep->speed),
             usb_str_transfer_type_short(instance->ep->transfer_type),
-            instance->transfered_size, str_error(instance->error), instance->error);
+            instance->transfered_size, str_error(instance->error),
+            instance->error);
 
         instance->callback_in(instance->fun, instance->error,
@@ -147 +148 @@
         assert(instance->callback_out);
 
-        usb_log_debug("Batch %p done (T%d.%d, %s %s out): %s (%d).\n",
+        usb_log_debug("Batch(%p) done (T%d.%d, %s %s out): %s (%d).\n",
             instance, instance->ep->address, instance->ep->endpoint,
             usb_str_speed(instance->ep->speed),