Changes in uspace/app/ping/ping.c [a2e3ee6:07b7c48] in mainline

File:

• uspace/app/ping/ping.c (modified) (12 diffs)

uspace/app/ping/ping.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2013 Jiri Svoboda
+ * Copyright (c) 2012 Jiri Svoboda
  * All rights reserved.
  *
@@ -37 +37 @@
 #include <errno.h>
 #include <fibril_synch.h>
-#include <inet/dnsr.h>
-#include <inet/addr.h>
 #include <inet/inetping.h>
 #include <io/console.h>
@@ -63 +61 @@
 };
 
-static uint32_t src;
-static uint32_t dest;
+static inet_addr_t src_addr;
+static inet_addr_t dest_addr;
 
 static bool ping_repeat = false;
@@ -70 +68 @@
 static void print_syntax(void)
 {
-        printf("syntax: " NAME " [-r] <host>\n");
+        printf("syntax: " NAME " [-r] <addr>\n");
+}
+
+static int addr_parse(const char *text, inet_addr_t *addr)
+{
+        unsigned long a[4];
+        char *cp = (char *)text;
+        int i;
+
+        for (i = 0; i < 3; i++) {
+                a[i] = strtoul(cp, &cp, 10);
+                if (*cp != '.')
+                        return EINVAL;
+                ++cp;
+        }
+
+        a[3] = strtoul(cp, &cp, 10);
+        if (*cp != '\0')
+                return EINVAL;
+
+        addr->ipv4 = 0;
+        for (i = 0; i < 4; i++) {
+                if (a[i] > 255)
+                        return EINVAL;
+                addr->ipv4 = (addr->ipv4 << 8) | a[i];
+        }
+
+        return EOK;
+}
+
+static int addr_format(inet_addr_t *addr, char **bufp)
+{
+        int rc;
+
+        rc = asprintf(bufp, "%d.%d.%d.%d", addr->ipv4 >> 24,
+            (addr->ipv4 >> 16) & 0xff, (addr->ipv4 >> 8) & 0xff,
+            addr->ipv4 & 0xff);
+
+        if (rc < 0)
+                return ENOMEM;
+
+        return EOK;
 }
 
@@ -83 +122 @@
 static int ping_ev_recv(inetping_sdu_t *sdu)
 {
-        inet_addr_t src_addr;
-        inet_addr_unpack(sdu->src, &src_addr);
-        
-        inet_addr_t dest_addr;
-        inet_addr_unpack(sdu->dest, &dest_addr);
-        
-        char *asrc;
-        int rc = inet_addr_format(&src_addr, &asrc);
+        char *asrc, *adest;
+        int rc;
+
+        rc = addr_format(&sdu->src, &asrc);
         if (rc != EOK)
                 return ENOMEM;
-        
-        char *adest;
-        rc = inet_addr_format(&dest_addr, &adest);
+
+        rc = addr_format(&sdu->dest, &adest);
         if (rc != EOK) {
                 free(asrc);
                 return ENOMEM;
         }
-        
         printf("Received ICMP echo reply: from %s to %s, seq. no %u, "
             "payload size %zu\n", asrc, adest, sdu->seq_no, sdu->size);
-        
-        if (!ping_repeat)
+
+        if (!ping_repeat) {
                 ping_signal_done();
-        
+        }
+
         free(asrc);
         free(adest);
@@ -117 +151 @@
         int rc;
 
-        sdu.src = src;
-        sdu.dest = dest;
+        sdu.src = src_addr;
+        sdu.dest = dest_addr;
         sdu.seq_no = seq_no;
         sdu.data = (void *) "foo";
@@ -179 +213 @@
 int main(int argc, char *argv[])
 {
-        dnsr_hostinfo_t *hinfo = NULL;
-        char *asrc = NULL;
-        char *adest = NULL;
-        char *sdest = NULL;
         int rc;
         int argi;
@@ -190 +220 @@
                 printf(NAME ": Failed connecting to internet ping service "
                     "(%d).\n", rc);
-                goto error;
+                return 1;
         }
 
@@ -203 +233 @@
         if (argc - argi != 1) {
                 print_syntax();
-                goto error;
+                return 1;
         }
 
         /* Parse destination address */
-        inet_addr_t dest_addr;
-        rc = inet_addr_parse(argv[argi], &dest_addr);
-        if (rc != EOK) {
-                /* Try interpreting as a host name */
-                rc = dnsr_name2host(argv[argi], &hinfo);
-                if (rc != EOK) {
-                        printf(NAME ": Error resolving host '%s'.\n", argv[argi]);
-                        goto error;
-                }
-                
-                dest_addr = hinfo->addr;
-        }
-        
-        rc = inet_addr_pack(&dest_addr, &dest);
-        if (rc != EOK) {
-                printf(NAME ": Destination '%s' is not an IPv4 address.\n",
-                    argv[argi]);
-                goto error;
-        }
-        
+        rc = addr_parse(argv[argi], &dest_addr);
+        if (rc != EOK) {
+                printf(NAME ": Invalid address format.\n");
+                print_syntax();
+                return 1;
+        }
+
         /* Determine source address */
-        rc = inetping_get_srcaddr(dest, &src);
+        rc = inetping_get_srcaddr(&dest_addr, &src_addr);
         if (rc != EOK) {
                 printf(NAME ": Failed determining source address.\n");
-                goto error;
-        }
-        
-        inet_addr_t src_addr;
-        inet_addr_unpack(src, &src_addr);
-        
-        rc = inet_addr_format(&src_addr, &asrc);
-        if (rc != EOK) {
-                printf(NAME ": Out of memory.\n");
-                goto error;
-        }
-        
-        rc = inet_addr_format(&dest_addr, &adest);
-        if (rc != EOK) {
-                printf(NAME ": Out of memory.\n");
-                goto error;
-        }
-        
-        if (hinfo != NULL) {
-                rc = asprintf(&sdest, "%s (%s)", hinfo->cname, adest);
-                if (rc < 0) {
-                        printf(NAME ": Out of memory.\n");
-                        goto error;
-                }
-        } else {
-                sdest = adest;
-                adest = NULL;
-        }
-
-        printf("Sending ICMP echo request from %s to %s.\n",
-            asrc, sdest);
+                return 1;
+        }
 
         fid_t fid;
@@ -269 +257 @@
                 if (fid == 0) {
                         printf(NAME ": Failed creating transmit fibril.\n");
-                        goto error;
+                        return 1;
                 }
 
@@ -277 +265 @@
                 if (fid == 0) {
                         printf(NAME ": Failed creating input fibril.\n");
-                        goto error;
+                        return 1;
                 }
 
@@ -295 +283 @@
         if (rc == ETIMEOUT) {
                 printf(NAME ": Echo request timed out.\n");
-                goto error;
-        }
-
-        free(asrc);
-        free(adest);
-        free(sdest);
-        dnsr_hostinfo_destroy(hinfo);
+                return 1;
+        }
+
         return 0;
-        
-error:
-        free(asrc);
-        free(adest);
-        free(sdest);
-        dnsr_hostinfo_destroy(hinfo);
-        return 1;
 }