Changes in uspace/srv/net/nil/eth/eth.c [4ef32e0c:0a3fbc7] in mainline

File:

• uspace/srv/net/nil/eth/eth.c (modified) (20 diffs)

uspace/srv/net/nil/eth/eth.c

@@ -42 +42 @@
 #include <byteorder.h>
 #include <str.h>
-#include <errno.h>
+#include <err.h>
 
 #include <ipc/ipc.h>
@@ -196 +196 @@
 int nil_initialize(int net_phone)
 {
-        int rc;
+        ERROR_DECLARE;
 
         fibril_rwlock_initialize(&eth_globals.devices_lock);
@@ -208 +208 @@
             CONVERT_SIZE(uint8_t, char, ETH_ADDR));
         if (!eth_globals.broadcast_addr) {
-                rc = ENOMEM;
+                ERROR_CODE = ENOMEM;
                 goto out;
         }
-        rc = eth_devices_initialize(&eth_globals.devices);
-        if (rc != EOK) {
+        if (ERROR_OCCURRED(eth_devices_initialize(&eth_globals.devices))) {
                 free(eth_globals.broadcast_addr);
                 goto out;
         }
-        rc = eth_protos_initialize(&eth_globals.protos);
-        if (rc != EOK) {
+        if (ERROR_OCCURRED(eth_protos_initialize(&eth_globals.protos))) {
                 free(eth_globals.broadcast_addr);
                 eth_devices_destroy(&eth_globals.devices);
@@ -225 +223 @@
         fibril_rwlock_write_unlock(&eth_globals.devices_lock);
         
-        return rc;
+        return ERROR_CODE;
 }
 
@@ -236 +234 @@
 static void eth_receiver(ipc_callid_t iid, ipc_call_t *icall)
 {
+        ERROR_DECLARE;
+
         packet_t packet;
-        int rc;
 
         while (true) {
@@ -247 +246 @@
                         break;
                 case NET_NIL_RECEIVED:
-                        rc = packet_translate_remote(eth_globals.net_phone,
-                            &packet, IPC_GET_PACKET(icall));
-                        if (rc == EOK) {
-                                rc = nil_received_msg_local(0,
+                        if (ERROR_NONE(packet_translate_remote(
+                            eth_globals.net_phone, &packet,
+                            IPC_GET_PACKET(icall)))) {
+                                ERROR_CODE = nil_received_msg_local(0,
                                     IPC_GET_DEVICE(icall), packet, 0);
                         }
-                        ipc_answer_0(iid, (ipcarg_t) rc);
+                        ipc_answer_0(iid, (ipcarg_t) ERROR_CODE);
                         break;
                 default:
@@ -283 +282 @@
 eth_device_message(device_id_t device_id, services_t service, size_t mtu)
 {
+        ERROR_DECLARE;
+
         eth_device_ref device;
         int index;
@@ -299 +300 @@
         char *data;
         eth_proto_ref proto;
-        int rc;
 
         fibril_rwlock_write_lock(&eth_globals.devices_lock);
@@ -351 +351 @@
 
         configuration = &names[0];
-        rc = net_get_device_conf_req(eth_globals.net_phone, device->device_id,
-            &configuration, count, &data);
-        if (rc != EOK) {
+        if (ERROR_OCCURRED(net_get_device_conf_req(eth_globals.net_phone,
+            device->device_id, &configuration, count, &data))) {
                 fibril_rwlock_write_unlock(&eth_globals.devices_lock);
                 free(device);
-                return rc;
+                return ERROR_CODE;
         }
         if (configuration) {
@@ -388 +387 @@
         
         // get hardware address
-        rc = netif_get_addr_req(device->phone, device->device_id, &device->addr,
-            &device->addr_data);
-        if (rc != EOK) {
+        if (ERROR_OCCURRED(netif_get_addr_req(device->phone, device->device_id,
+            &device->addr, &device->addr_data))) {
                 fibril_rwlock_write_unlock(&eth_globals.devices_lock);
                 free(device);
-                return rc;
+                return ERROR_CODE;
         }
         
@@ -431 +429 @@
 static eth_proto_ref eth_process_packet(int flags, packet_t packet)
 {
+        ERROR_DECLARE;
+
         eth_header_snap_ref header;
         size_t length;
@@ -437 +437 @@
         size_t suffix;
         eth_fcs_ref fcs;
-        uint8_t *data;
-        int rc;
+        uint8_t * data;
 
         length = packet_get_data_length(packet);
@@ -489 +488 @@
         
         if (IS_DUMMY(flags)) {
-                if (~compute_crc32(~0U, data, length * 8) != ntohl(*fcs))
+                if ((~compute_crc32(~0U, data, length * 8)) != ntohl(*fcs))
                         return NULL;
                 suffix += sizeof(eth_fcs_t);
         }
         
-        rc = packet_set_addr(packet, header->header.source_address,
-            header->header.destination_address, ETH_ADDR);
-        if (rc != EOK)
+        if (ERROR_OCCURRED(packet_set_addr(packet,
+            header->header.source_address, header->header.destination_address,
+            ETH_ADDR)) || ERROR_OCCURRED(packet_trim(packet, prefix, suffix))) {
                 return NULL;
-
-        rc = packet_trim(packet, prefix, suffix);
-        if (rc != EOK)
-                return NULL;
+        }
         
         return eth_protos_find(&eth_globals.protos, type);
@@ -785 +781 @@
 eth_send_message(device_id_t device_id, packet_t packet, services_t sender)
 {
+        ERROR_DECLARE;
+
         eth_device_ref device;
         packet_t next;
         packet_t tmp;
         int ethertype;
-        int rc;
 
         ethertype = htons(protocol_map(SERVICE_ETHERNET, sender));
@@ -807 +804 @@
         next = packet;
         do {
-                rc = eth_prepare_packet(device->flags, next,
-                    (uint8_t *) device->addr->value, ethertype, device->mtu);
-                if (rc != EOK) {
+                if (ERROR_OCCURRED(eth_prepare_packet(device->flags, next,
+                    (uint8_t *) device->addr->value, ethertype, device->mtu))) {
                         // release invalid packet
                         tmp = pq_detach(next);
@@ -836 +832 @@
     ipc_call_t *answer, int *answer_count)
 {
+        ERROR_DECLARE;
+        
         measured_string_ref address;
         packet_t packet;
@@ -842 +840 @@
         size_t suffix;
         size_t content;
-        int rc;
         
         *answer_count = 0;
@@ -853 +850 @@
                     IPC_GET_SERVICE(call), IPC_GET_MTU(call));
         case NET_NIL_SEND:
-                rc = packet_translate_remote(eth_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
-                if (rc != EOK)
-                        return rc;
+                ERROR_PROPAGATE(packet_translate_remote(eth_globals.net_phone,
+                    &packet, IPC_GET_PACKET(call)));
                 return eth_send_message(IPC_GET_DEVICE(call), packet,
                     IPC_GET_SERVICE(call));
         case NET_NIL_PACKET_SPACE:
-                rc = eth_packet_space_message(IPC_GET_DEVICE(call), &addrlen,
-                    &prefix, &content, &suffix);
-                if (rc != EOK)
-                        return rc;
+                ERROR_PROPAGATE(eth_packet_space_message(IPC_GET_DEVICE(call),
+                    &addrlen, &prefix, &content, &suffix));
                 IPC_SET_ADDR(answer, addrlen);
                 IPC_SET_PREFIX(answer, prefix);
@@ -871 +864 @@
                 return EOK;
         case NET_NIL_ADDR:
-                rc = eth_addr_message(IPC_GET_DEVICE(call), ETH_LOCAL_ADDR,
-                    &address);
-                if (rc != EOK)
-                        return rc;
+                ERROR_PROPAGATE(eth_addr_message(IPC_GET_DEVICE(call),
+                    ETH_LOCAL_ADDR, &address));
                 return measured_strings_reply(address, 1);
         case NET_NIL_BROADCAST_ADDR:
-                rc = eth_addr_message(IPC_GET_DEVICE(call), ETH_BROADCAST_ADDR,
-                    &address);
-                if (rc != EOK)
-                        return EOK;
+                ERROR_PROPAGATE(eth_addr_message(IPC_GET_DEVICE(call),
+                    ETH_BROADCAST_ADDR, &address));
                 return measured_strings_reply(address, 1);
         case IPC_M_CONNECT_TO_ME:
@@ -934 +923 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        ERROR_DECLARE;
         
         /* Start the module */
-        rc = nil_module_start_standalone(nil_client_connection);
-        return rc;
+        ERROR_PROPAGATE(nil_module_start_standalone(nil_client_connection));
+        return EOK;
 }