Changes in uspace/lib/usbhid/src/hidparser.c [b72efe8:0dd3e49] in mainline

File:

• uspace/lib/usbhid/src/hidparser.c (modified) (9 diffs)

uspace/lib/usbhid/src/hidparser.c

@@ -135 +135 @@
         size_t size, uint8_t *report_id)
 {
+        link_t *list_item;
         usb_hid_report_field_t *item;
 
@@ -160 +161 @@
 
         /* read data */
-        list_foreach(report_des->report_items, list_item) {
+        list_item = report_des->report_items.next;         
+        while(list_item != &(report_des->report_items)) {
+
                 item = list_get_instance(list_item, usb_hid_report_field_t, 
-                                ritems_link);
+                                link);
 
                 if(USB_HID_ITEM_FLAG_CONSTANT(item->item_flags) == 0) {
@@ -197 +200 @@
                         }                       
                 }
+                list_item = list_item->next;
         }
         
@@ -306 +310 @@
         }
 
+        link_t *report_it = report->reports.next;
         usb_hid_report_description_t *report_des = NULL;
-
-        list_foreach(report->reports, report_it) {
-                report_des = list_get_instance(report_it,
-                        usb_hid_report_description_t, reports_link);
+        while(report_it != &report->reports) {
+                report_des = list_get_instance(report_it, 
+                        usb_hid_report_description_t, link);
                 
-                if((report_des->report_id == report_id) &&
+                if((report_des->report_id == report_id) && 
                         (report_des->type == USB_HID_REPORT_TYPE_OUTPUT)){
                         break;
                 }
+
+                report_it = report_it->next;
         }
 
@@ -356 +362 @@
         uint8_t report_id, uint8_t *buffer, size_t size)
 {
+        link_t *item;   
         int32_t value=0;
         int offset;
@@ -377 +384 @@
         }
 
-        usb_hid_report_field_t *report_item;
-
-        list_foreach(report_des->report_items, item) {
-                report_item = list_get_instance(item, usb_hid_report_field_t,
-                    ritems_link);
+        usb_hid_report_field_t *report_item;    
+        item = report_des->report_items.next;   
+        while(item != &report_des->report_items) {
+                report_item = list_get_instance(item, usb_hid_report_field_t, link);
 
                 value = usb_hid_translate_data_reverse(report_item, 
@@ -443 +449 @@
                 // reset value
                 report_item->value = 0;
+                
+                item = item->next;
         }
         
@@ -542 +550 @@
 
         if(field == NULL){
-                field_it = report_des->report_items.head.next;
-        }
-        else {
-                field_it = field->ritems_link.next;
-        }
-
-        while(field_it != &report_des->report_items.head) {
+                field_it = report_des->report_items.next;
+        }
+        else {
+                field_it = field->link.next;
+        }
+
+        while(field_it != &report_des->report_items) {
                 field = list_get_instance(field_it, usb_hid_report_field_t, 
-                        ritems_link);
+                        link);
 
                 if(USB_HID_ITEM_FLAG_CONSTANT(field->item_flags) == 0) {
@@ -603 +611 @@
                 }
                 else {
-                        report_it = report_des->reports_link.next;
+                        report_it = report_des->link.next;
                 }       
         }
         else {
-                report_it = report->reports.head.next;
-        }
-
-        while(report_it != &report->reports.head) {
+                report_it = report->reports.next;
+        }
+
+        while(report_it != &report->reports) {
                 report_des = list_get_instance(report_it, 
-                        usb_hid_report_description_t, reports_link);
+                        usb_hid_report_description_t, link);
 
                 if(report_des->type == type){