Changeset 0f4f1b2 in mainline for kernel/test/mm/falloc2.c

Timestamp:

2024-01-15T17:10:27Z (9 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

e82879c

Parents:

a064d4f

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 16:37:22)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 17:10:27)

Message:

Add (and use) functions thread_start() and thread_detach()

Mostly cosmetic, with thread_start() replacing calls to thread_ready(),
but not consuming the passed reference, and thread_detach() being
synonym for thread_put(). Makes the code's function more obvious.

Also modify some threaded tests to use thread_join() for waiting,
instead of counting threads with atomics or semaphores.

File:

• kernel/test/mm/falloc2.c (modified) (4 diffs)

kernel/test/mm/falloc2.c

@@ -43 +43 @@
 #define THREADS      8
 
-static atomic_size_t thread_cnt;
 static atomic_size_t thread_fail;
 
@@ -56 +55 @@
                     "Unable to allocate frames\n", THREAD->tid, CPU->id);
                 atomic_inc(&thread_fail);
-                atomic_dec(&thread_cnt);
                 return;
         }
@@ -108 +106 @@
         TPRINTF("Thread #%" PRIu64 " (cpu%u): Exiting\n",
             THREAD->tid, CPU->id);
-        atomic_dec(&thread_cnt);
 }
 
 const char *test_falloc2(void)
 {
-        atomic_store(&thread_cnt, THREADS);
         atomic_store(&thread_fail, 0);
+
+        thread_t *threads[THREADS] = { };
 
         for (unsigned int i = 0; i < THREADS; i++) {
@@ -123 +121 @@
                         break;
                 }
-                thread_ready(thrd);
+                thread_start(thrd);
+                threads[i] = thrd;
         }
 
-        while (atomic_load(&thread_cnt) > 0) {
-                TPRINTF("Threads left: %zu\n",
-                    atomic_load(&thread_cnt));
-                thread_sleep(1);
+        for (unsigned int i = 0; i < THREADS; i++) {
+                if (threads[i] != NULL)
+                        thread_join(threads[i]);
+
+                TPRINTF("Threads left: %u\n", THREADS - i - 1);
         }