Changeset 0f4f1b2 in mainline for kernel/test/thread/thread1.c

Timestamp:

2024-01-15T17:10:27Z (11 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

e82879c

Parents:

a064d4f

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 16:37:22)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 17:10:27)

Message:

Add (and use) functions thread_start() and thread_detach()

Mostly cosmetic, with thread_start() replacing calls to thread_ready(),
but not consuming the passed reference, and thread_detach() being
synonym for thread_put(). Makes the code's function more obvious.

Also modify some threaded tests to use thread_join() for waiting,
instead of counting threads with atomics or semaphores.

File:

• kernel/test/thread/thread1.c (modified) (3 diffs)

kernel/test/thread/thread1.c

@@ -38 +38 @@
 
 static atomic_bool finish;
-static atomic_size_t threads_finished;
 
 static void threadtest(void *data)
@@ -46 +45 @@
                 thread_usleep(100000);
         }
-        atomic_inc(&threads_finished);
 }
 
 const char *test_thread1(void)
 {
-        unsigned int i;
-        size_t total = 0;
+        atomic_store(&finish, true);
 
-        atomic_store(&finish, true);
-        atomic_store(&threads_finished, 0);
+        thread_t *threads[THREADS] = { };
 
-        for (i = 0; i < THREADS; i++) {
-                thread_t *t;
-                if (!(t = thread_create(threadtest, NULL, TASK,
-                    THREAD_FLAG_NONE, "threadtest"))) {
+        for (int i = 0; i < THREADS; i++) {
+                threads[i] = thread_create(threadtest, NULL,
+                    TASK, THREAD_FLAG_NONE, "threadtest");
+
+                if (threads[i]) {
+                        thread_start(threads[i]);
+                } else {
                         TPRINTF("Could not create thread %d\n", i);
                         break;
                 }
-                thread_ready(t);
-                total++;
         }
 
@@ -72 +69 @@
 
         atomic_store(&finish, false);
-        while (atomic_load(&threads_finished) < total) {
-                TPRINTF("Threads left: %zu\n", total - atomic_load(&threads_finished));
-                thread_sleep(1);
+
+        for (int i = 0; i < THREADS; i++) {
+                if (threads[i] != NULL)
+                        thread_join(threads[i]);
+
+                TPRINTF("Threads left: %d\n", THREADS - i - 1);
         }