Changeset 10e56b7 in mainline for uspace/lib/c/generic/rtld/symbol.c

Timestamp:

2023-07-14T12:41:26Z (19 months ago)

Author:

Vojtech Horky <vojtech.horky@…>

Branches:

ticket/834-toolchain-update

Children:

f1e7599

Parents:

c4c90c8

git-author:

Vojtech Horky <vojtech.horky@…> (2023-07-14 09:54:21)

git-committer:

Vojtech Horky <vojtech.horky@…> (2023-07-14 12:41:26)

Message:

Bypass compiler false-alarm

File:

• uspace/lib/c/generic/rtld/symbol.c (modified) (1 diff)

uspace/lib/c/generic/rtld/symbol.c

@@ -135 +135 @@
         modules_untag(start->rtld);
 
-        /* Insert root (the program) into the queue and tag it */
+        /*
+         * Insert root (the program) into the queue and tag it.
+         *
+         * We disable the dangling-pointer warning because the compiler incorrectly
+         * assumes that we leak local address (queue) to a parent scope (to start
+         * argument). However, we always empty the list so the pointer cannot
+         * actually escape. Probably the compiler can never statically analyze that
+         * correctly.
+         */
         list_initialize(&queue);
         start->bfs_tag = true;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdangling-pointer"
         list_append(&start->queue_link, &queue);
+#pragma GCC diagnostic pop
 
         /* If the symbol is found, it will be stored in 'sym' */