Changes in / [166c4752:1181249] in mainline

Location:

uspace/lib/usb/src

Files:

• hiddescriptor.c (modified) (6 diffs)
• hidparser.c (modified) (1 diff)

uspace/lib/usb/src/hiddescriptor.c

@@ -101 +101 @@
 }
 
-
-/*
- *
- *
- */
 int usb_hid_report_append_fields(usb_hid_report_t *report, usb_hid_report_item_t *report_item)
 {
@@ -139 +134 @@
                 if(report_item->usages_count > 0 && ((report_item->usage_minimum == 0) && (report_item->usage_maximum == 0))) {
                         uint32_t usage;
-                        if(i < report_item->usages_count){
-                                usage = report_item->usages[i];
+                        if(report_item->type != USB_HID_REPORT_TYPE_OUTPUT) {
+                                if(i < report_item->usages_count){
+                                        usage = report_item->usages[i];
+                                }
+                                else {
+                                        usage = report_item->usages[report_item->usages_count - 1];
+                                }
                         }
                         else {
-                                usage = report_item->usages[report_item->usages_count - 1];
+                                if((report_item->count - i - 1) < report_item->usages_count){
+                                        usage = report_item->usages[(report_item->count - i - 1)];
+                                }
+                                else {
+                                        usage = report_item->usages[report_item->usages_count - 1];
+                                }
                         }
 
@@ -159 +164 @@
 
                 if((USB_HID_ITEM_FLAG_VARIABLE(report_item->item_flags) != 0) && (!((report_item->usage_minimum == 0) && (report_item->usage_maximum == 0)))) {
-                        field->usage = report_item->usage_minimum + i;                                  
+                        if(report_item->type == USB_HID_REPORT_TYPE_INPUT) {
+                                field->usage = report_item->usage_maximum - i;
+                        }
+                        else {
+                                field->usage = report_item->usage_minimum + i;                                  
+                        }
+
                 }
                 
@@ -168 +179 @@
 
                 field->size = report_item->size;
-                
-                size_t offset_byte = (report_item->offset + (i * report_item->size)) / 8;
-                size_t offset_bit = 8 - ((report_item->offset + (i * report_item->size)) % 8) - report_item->size;
-
-                field->offset = 8 * offset_byte + offset_bit;
+                field->offset = report_item->offset + (i * report_item->size);
                 if(report_item->id != 0) {
                         field->offset += 8;
@@ -633 +640 @@
 
                 usb_log_debug("\t\tOFFSET: %X\n", report_item->offset);
-                usb_log_debug("\t\tSIZE: %X\n", report_item->size);                             
+                usb_log_debug("\t\tSIZE: %zu\n", report_item->size);
                 usb_log_debug("\t\tLOGMIN: %d\n", report_item->logical_minimum);
                 usb_log_debug("\t\tLOGMAX: %d\n", report_item->logical_maximum);                
@@ -672 +679 @@
                 usb_log_debug("Report ID: %d\n", report_des->report_id);
                 usb_log_debug("\tType: %d\n", report_des->type);
-                usb_log_debug("\tLength: %d\n", report_des->bit_length);                
-                usb_log_debug("\tItems: %d\n", report_des->item_length);                
+                usb_log_debug("\tLength: %zu\n", report_des->bit_length);
+                usb_log_debug("\tItems: %zu\n", report_des->item_length);
 
                 usb_hid_descriptor_print_list(&report_des->report_items);

uspace/lib/usb/src/hidparser.c

@@ -405 +405 @@
                                 }
 
-                                size_t shift = 8 - offset%8 - length;
+                                size_t shift = offset%8;
 
                                 value = value << shift;