Changeset 133461c in mainline for uspace/lib/c/arch/arm32/src/atomic.c

Timestamp:

2023-10-22T17:49:28Z (13 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1c6c3e1d, cc73f6d4

Parents:

78f0422c

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 17:44:39)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 17:49:28)

Message:

Align arm32 atomic op prototypes with compiler's expectations

Based on a patch by @vhotspur, but without explicit casts
between pointer types. Those are evil footguns.

File:

• uspace/lib/c/arch/arm32/src/atomic.c (modified) (4 diffs)

uspace/lib/c/arch/arm32/src/atomic.c

@@ -38 +38 @@
 volatile unsigned *ras_page;
 
-bool __atomic_compare_exchange_4(volatile unsigned *mem, unsigned *expected, unsigned desired, bool weak, int success, int failure)
+bool __atomic_compare_exchange_4(volatile void *mem0, void *expected0,
+    unsigned desired, bool weak, int success, int failure)
 {
+        volatile unsigned *mem = mem0;
+        unsigned *expected = expected0;
+
         (void) success;
         (void) failure;
@@ -82 +86 @@
 }
 
-unsigned short __atomic_fetch_add_2(volatile unsigned short *mem, unsigned short val, int model)
+unsigned short __atomic_fetch_add_2(volatile void *mem0, unsigned short val,
+    int model)
 {
+        volatile unsigned short *mem = mem0;
+
         (void) model;
 
@@ -116 +123 @@
 }
 
-unsigned __atomic_fetch_add_4(volatile unsigned *mem, unsigned val, int model)
+unsigned __atomic_fetch_add_4(volatile void *mem0, unsigned val, int model)
 {
+        volatile unsigned *mem = mem0;
+
         (void) model;
 
@@ -150 +159 @@
 }
 
-unsigned __atomic_fetch_sub_4(volatile unsigned *mem, unsigned val, int model)
+unsigned __atomic_fetch_sub_4(volatile void *mem, unsigned val, int model)
 {
         return __atomic_fetch_add_4(mem, -val, model);