Changes in uspace/srv/ns/task.c [234f47e:166a1f57] in mainline

File:

• uspace/srv/ns/task.c (modified) (8 diffs)

uspace/srv/ns/task.c

@@ -40 +40 @@
 #include <macros.h>
 #include <malloc.h>
-#include <types/task.h>
 #include "task.h"
 #include "ns.h"
 
+
+/* TODO:
+ *
+ * As there is currently no convention that each task has to be waited
+ * for, the NS can leak memory because of the zombie tasks.
+ *
+ */
 
 /** Task hash table item. */
@@ -173 +179 @@
         
 loop:
-        list_foreach(pending_wait, link, pending_wait_t, pr) {
+        list_foreach(pending_wait, cur) {
+                pending_wait_t *pr = list_get_instance(cur, pending_wait_t, link);
+                
                 ht_link_t *link = hash_table_find(&task_hash_table, &pr->id);
                 if (!link)
@@ -189 +197 @@
                 }
                 
-                list_remove(&pr->link);
+                hash_table_remove(&task_hash_table, &pr->id);
+                list_remove(cur);
                 free(pr);
                 goto loop;
@@ -197 +206 @@
 void wait_for_task(task_id_t id, ipc_call_t *call, ipc_callid_t callid)
 {
+        sysarg_t retval;
+        task_exit_t texit;
+        bool remove = false;
+        
         ht_link_t *link = hash_table_find(&task_hash_table, &id);
         hashed_task_t *ht = (link != NULL) ?
@@ -207 +220 @@
         }
         
-        if (ht->finished) {
-                task_exit_t texit = ht->have_rval ? TASK_EXIT_NORMAL :
-                    TASK_EXIT_UNEXPECTED;
-                ipc_answer_2(callid, EOK, texit, ht->retval);
+        if (!ht->finished) {
+                /* Add to pending list */
+                pending_wait_t *pr =
+                    (pending_wait_t *) malloc(sizeof(pending_wait_t));
+                if (!pr) {
+                        retval = ENOMEM;
+                        goto out;
+                }
+                
+                link_initialize(&pr->link);
+                pr->id = id;
+                pr->callid = callid;
+                list_append(&pr->link, &pending_wait);
                 return;
         }
         
-        /* Add to pending list */
-        pending_wait_t *pr =
-            (pending_wait_t *) malloc(sizeof(pending_wait_t));
-        if (!pr) {
-                if (!(callid & IPC_CALLID_NOTIFICATION))
-                        ipc_answer_0(callid, ENOMEM);
-                return;
-        }
-        
-        link_initialize(&pr->link);
-        pr->id = id;
-        pr->callid = callid;
-        list_append(&pr->link, &pending_wait);
+        remove = true;
+        retval = EOK;
+        
+out:
+        if (!(callid & IPC_CALLID_NOTIFICATION)) {
+                texit = ht->have_rval ? TASK_EXIT_NORMAL : TASK_EXIT_UNEXPECTED;
+                ipc_answer_2(callid, retval, texit, ht->retval);
+        }
+        if (remove)
+                hash_table_remove_item(&task_hash_table, link);
 }
 
 int ns_task_id_intro(ipc_call_t *call)
 {
+        
         task_id_t id = MERGE_LOUP32(IPC_GET_ARG1(*call), IPC_GET_ARG2(*call));
-        
+
         ht_link_t *link = hash_table_find(&phone_to_id, &call->in_phone_hash);
         if (link != NULL)
-                return EEXIST;
+                return EEXISTS;
         
         p2i_entry_t *entry = (p2i_entry_t *) malloc(sizeof(p2i_entry_t));
@@ -242 +262 @@
         
         hashed_task_t *ht = (hashed_task_t *) malloc(sizeof(hashed_task_t));
-        if (ht == NULL) {
-                free(entry);
+        if (ht == NULL)
                 return ENOMEM;
-        }
         
         /*
@@ -298 +316 @@
         ht->retval = IPC_GET_ARG1(*call);
         
-        process_pending_wait();
-        
         return EOK;
 }
@@ -322 +338 @@
         ht->finished = true;
         
-        process_pending_wait();
-        hash_table_remove(&task_hash_table, &id);
-        
         return EOK;
 }