Changes in / [1d7a74e:192466bc] in mainline

Location:

uspace/drv/usbhub

Files:

• main.c (modified) (1 diff)
• usbhub.c (modified) (15 diffs)
• usbhub_private.h (modified) (6 diffs)

uspace/drv/usbhub/main.c

@@ -52 +52 @@
         while(true){
                 usb_hub_check_hub_changes();
-                async_usleep(1000 * 1000);
+                async_usleep(1000 * 1000 );/// \TODO proper number once
         }
         return 0;

uspace/drv/usbhub/usbhub.c

@@ -46 +46 @@
 #include "usbhub_private.h"
 #include "port_status.h"
+#include "usb/usb.h"
 
 static usb_iface_t hub_usb_iface = {
@@ -85 +86 @@
 
         // get hub descriptor
-        usb_target_t target;
-        target.address = addr;
-        target.endpoint = 0;
-        usb_device_request_setup_packet_t request;
-        //printf("[usb_hub] creating descriptor request\n");
-        usb_hub_set_descriptor_request(&request);
 
         //printf("[usb_hub] creating serialized descriptor\n");
@@ -98 +93 @@
         int opResult;
         //printf("[usb_hub] starting control transaction\n");
-        opResult = usb_drv_sync_control_read(
-                        hc, target, &request, serialized_descriptor,
+        
+        opResult = usb_drv_req_get_descriptor(hc, addr,
+                        USB_REQUEST_TYPE_CLASS,
+                        USB_DESCTYPE_HUB, 0, 0, serialized_descriptor,
                         USB_HUB_MAX_DESCRIPTOR_SIZE, &received_size);
+
         if (opResult != EOK) {
                 dprintf(1,"[usb_hub] failed when receiving hub descriptor, badcode = %d",opResult);
@@ -155 +153 @@
         int port;
         int opResult;
-        usb_device_request_setup_packet_t request;
         usb_target_t target;
         target.address = hub_info->usb_device->address;
@@ -173 +170 @@
         if(std_descriptor.configuration_count<1){
                 dprintf(1,"[usb_hub] THERE ARE NO CONFIGURATIONS AVAILABLE");
+                //shouldn`t I return?
         }
         /// \TODO check other configurations
@@ -184 +182 @@
         }
         //set configuration
-        request.request_type = 0;
-        request.request = USB_DEVREQ_SET_CONFIGURATION;
-        request.index=0;
-        request.length=0;
-        request.value_high=0;
-        request.value_low = config_descriptor.configuration_number;
-        opResult = usb_drv_sync_control_write(hc, target, &request, NULL, 0);
+        opResult = usb_drv_req_set_configuration(hc, target.address,
+    config_descriptor.configuration_number);
+
         if (opResult != EOK) {
                 dprintf(1,"[usb_hub]something went wrong when setting hub`s configuration, %d", opResult);
         }
 
+        usb_device_request_setup_packet_t request;
         for (port = 1; port < hub_info->port_count+1; ++port) {
                 usb_hub_set_power_port_request(&request, port);
@@ -229 +224 @@
 
 
-
 //*********************************************
 //
@@ -237 +231 @@
 
 /**
- * convenience function for releasing default address and writing debug info
- * (these few lines are used too often to be written again and again)
+ * Convenience function for releasing default address and writing debug info
+ * (these few lines are used too often to be written again and again).
  * @param hc
  * @return
@@ -253 +247 @@
 
 /**
- * reset the port with new device and reserve the default address
+ * Reset the port with new device and reserve the default address.
  * @param hc
  * @param port
@@ -282 +276 @@
 
 /**
- * finalize adding new device after port reset
+ * Finalize adding new device after port reset
  * @param hc
  * @param port
@@ -345 +339 @@
 
 /**
- * unregister device address in hc
+ * Unregister device address in hc
  * @param hc
  * @param port
@@ -355 +349 @@
         int opResult;
         
-        /// \TODO remove device
+        /** \TODO remove device from device manager - not yet implemented in
+         * devide manager
+         */
 
         hub->attached_devs[port].devman_handle=0;
@@ -376 +372 @@
 
 /**
- * process interrupts on given hub port
+ * Process interrupts on given hub port
  * @param hc
  * @param port
@@ -434 +430 @@
         usb_port_set_reset_completed(&status, false);
         usb_port_set_dev_connected(&status, false);
-        if (status) {
-                dprintf(1,"[usb_hub]there was some unsupported change on port %d",port);
+        if (status>>16) {
+                dprintf(1,"[usb_hub]there was some unsupported change on port %d: %X",port,status);
+
         }
         /// \TODO handle other changes
@@ -442 +439 @@
 }
 
-/* Check changes on all known hubs.
+/**
+ * Check changes on all known hubs.
  */
 void usb_hub_check_hub_changes(void) {

uspace/drv/usbhub/usbhub_private.h

@@ -31 +31 @@
  */
 /** @file
- * @brief Hub driver.
+ * @brief Hub driver private definitions
  */
 
@@ -68 +68 @@
 
 /**
- * create hub structure instance
+ * Create hub structure instance
  *
  * Set the address and port count information most importantly.
@@ -78 +78 @@
 usb_hub_info_t * usb_create_hub_info(device_t * device, int hc);
 
-/** list of hubs maanged by this driver */
+/** List of hubs maanged by this driver */
 extern usb_general_list_t usb_hub_list;
 
-/** lock for hub list*/
+/** Lock for hub list*/
 extern futex_t usb_hub_list_lock;
 
 
 /**
- * perform complete control read transaction
+ * Perform complete control read transaction
  *
- * manages all three steps of transaction: setup, read and finalize
+ * Manages all three steps of transaction: setup, read and finalize
  * @param phone
  * @param target
- * @param request request for data
- * @param rcvd_buffer received data
+ * @param request Request packet
+ * @param rcvd_buffer Received data
  * @param rcvd_size
- * @param actual_size actual size of received data
+ * @param actual_size Actual size of received data
  * @return error code
  */
@@ -104 +104 @@
 
 /**
- * perform complete control write transaction
+ * Perform complete control write transaction
  *
- * manages all three steps of transaction: setup, write and finalize
+ * Manages all three steps of transaction: setup, write and finalize
  * @param phone
  * @param target
- * @param request request to send data
+ * @param request Request packet to send data
  * @param sent_buffer
  * @param sent_size
@@ -121 +121 @@
 
 /**
- * set the device request to be a get hub descriptor request.
+ * Set the device request to be a get hub descriptor request.
  * @warning the size is allways set to USB_HUB_MAX_DESCRIPTOR_SIZE
  * @param request
@@ -137 +137 @@
 }
 
+/**
+ * Clear feature on hub port.
+ *
+ * @param hc Host controller telephone
+ * @param address Hub address
+ * @param port_index Port
+ * @param feature Feature selector
+ * @return Operation result
+ */
 static inline int usb_hub_clear_port_feature(int hc, usb_address_t address,
     int port_index,