Changeset 1ba6651 in mainline

Timestamp:

2013-07-11T12:17:14Z (11 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3908355, cdc3afa

Parents:

64e63ce1

Message:

mfs: initialize the inode field "i_nlinks" to 0 when creating a new node; remove some debug messages and fix a warning.

File:

• uspace/srv/fs/mfs/mfs_ops.c (modified) (9 diffs)

uspace/srv/fs/mfs/mfs_ops.c

@@ -345 +345 @@
         uint32_t inum;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         r = mfs_instance_get(service_id, &inst);
         if (r != EOK)
@@ -379 +377 @@
                 ino_i->i_mode = S_IFDIR;
                 ino_i->i_nlinks = 1; /* This accounts for the '.' dentry */
-        } else
+        } else {
                 ino_i->i_mode = S_IFREG;
+                ino_i->i_nlinks = 0;
+        }
 
         ino_i->i_uid = 0;
@@ -431 +431 @@
         int r;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         if (!S_ISDIR(ino_i->i_mode))
                 return ENOTDIR;
@@ -479 +477 @@
         struct mfs_instance *instance;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         rc = mfs_instance_get(service_id, &instance);
         if (rc != EOK)
@@ -493 +489 @@
         int rc = EOK;
         struct mfs_node *mnode = fsnode->data;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         fibril_mutex_lock(&open_nodes_lock);
@@ -555 +549 @@
         int rc;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         fibril_mutex_lock(&open_nodes_lock);
 
@@ -650 +642 @@
         struct mfs_sb_info *sbi = parent->instance->sbi;
         bool destroy_dentry = false;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         if (str_size(name) > sbi->max_name_len)
@@ -703 +693 @@
         bool has_children;
         int r;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         if (!parent)
@@ -970 +958 @@
 mfs_destroy(service_id_t service_id, fs_index_t index)
 {
-        fs_node_t *fn;
+        fs_node_t *fn = NULL;
         int r;