Changeset 1cb75de in mainline for kernel/generic/src/ipc/ipc.c

Timestamp:

2012-08-14T20:17:12Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9956fad9

Parents:

86939b1

Message:

Remove an answered call from the task's active list when the call is
answered in _ipc_answer_free_call() rather than when the answer is
picked up by the sender task in ipc_wait_for_call().

This makes the maintainance of the active list symmetric because the
addition takes place in _ipc_call().

Moreover, unlike when tracking the phone's number of active calls, there
is no reason to postpone the removal from the active calls list until
ipc_wait_for_call().

File:

• kernel/generic/src/ipc/ipc.c (modified) (2 diffs)

kernel/generic/src/ipc/ipc.c

@@ -186 +186 @@
         }
 
+        /*
+         * Remove the call from the sender's active call list.
+         */
+        spinlock_lock(&call->sender->active_calls_lock);
+        list_remove(&call->ta_link);
+        spinlock_unlock(&call->sender->active_calls_lock);
+
         call->data.task_id = TASK->taskid;
         
@@ -429 +436 @@
                 list_remove(&request->ab_link);
                 atomic_dec(&request->data.phone->active_calls);
-
-                /*
-                 * Remove the call from this task's active call list.
-                 */
-                spinlock_lock(&TASK->active_calls_lock);
-                list_remove(&request->ta_link);
-                spinlock_unlock(&TASK->active_calls_lock);
         } else if (!list_empty(&box->calls)) {
                 /* Count received call */