Changes in uspace/lib/usbdev/src/request.c [9d58539:1cf26ab] in mainline

File:

• uspace/lib/usbdev/src/request.c (modified) (9 diffs)

uspace/lib/usbdev/src/request.c

@@ -39 +39 @@
 
 #define MAX_DATA_LENGTH ((size_t)(0xFFFF))
+
+static_assert(sizeof(usb_device_request_setup_packet_t) == 8);
 
 /** Generic wrapper for SET requests using standard control request format.
@@ -114 +116 @@
   *     (in native endianness).
   * @param actual_data_size Actual size of transfered data
-  *     (in native endianness).
+  *        (in native endianness).
   * @return Error code.
   * @retval EBADMEM @p pipe is NULL.
@@ -147 +149 @@
                     | (request_type << 5) | recipient,
                 .request = request,
-                .value = value,
-                .index = index,
-                .length = (uint16_t) data_size,
+                .value = uint16_host2usb(value),
+                .index = uint16_host2usb(index),
+                .length = uint16_host2usb(data_size),
         };
 
@@ -375 +377 @@
         usb_standard_device_descriptor_t descriptor_tmp;
         int rc = usb_request_get_descriptor(pipe,
-            USB_REQUEST_TYPE_STANDARD, USB_REQUEST_RECIPIENT_DEVICE, 
+            USB_REQUEST_TYPE_STANDARD, USB_REQUEST_RECIPIENT_DEVICE,
             USB_DESCTYPE_DEVICE, 0, 0,
             &descriptor_tmp, sizeof(descriptor_tmp),
@@ -435 +437 @@
         /* Everything is okay, copy the descriptor. */
         memcpy(descriptor, &descriptor_tmp, sizeof(descriptor_tmp));
-
         return EOK;
 }
@@ -495 +496 @@
                 return ENOENT;
         }
-        if (bare_config.total_length < sizeof(bare_config)) {
+
+        const size_t total_length = uint16_usb2host(bare_config.total_length);
+        if (total_length < sizeof(bare_config)) {
                 return ELIMIT;
         }
 
-        void *buffer = malloc(bare_config.total_length);
+        void *buffer = malloc(total_length);
         if (buffer == NULL) {
                 return ENOMEM;
@@ -506 +509 @@
         size_t transferred = 0;
         rc = usb_request_get_full_configuration_descriptor(pipe, index,
-            buffer, bare_config.total_length, &transferred);
+            buffer, total_length, &transferred);
         if (rc != EOK) {
                 free(buffer);
@@ -512 +515 @@
         }
 
-        if (transferred != bare_config.total_length) {
+        if (transferred != total_length) {
                 free(buffer);
                 return ELIMIT;
@@ -522 +525 @@
 
         if (descriptor_size != NULL) {
-                *descriptor_size = bare_config.total_length;
+                *descriptor_size = total_length;
         }