Changes in kernel/generic/src/ipc/irq.c [8add9ca5:1d432f9] in mainline

File:

• kernel/generic/src/ipc/irq.c (modified) (10 diffs)

kernel/generic/src/ipc/irq.c

@@ -42 +42 @@
  *
  * The structure of a notification message is as follows:
- * - IMETHOD: interface and method as registered by the SYS_REGISTER_IRQ
- *            syscall
+ * - METHOD: method as registered by the SYS_IPC_REGISTER_IRQ syscall
  * - ARG1: payload modified by a 'top-half' handler
  * - ARG2: payload modified by a 'top-half' handler
@@ -50 +49 @@
  * - ARG5: payload modified by a 'top-half' handler
  * - in_phone_hash: interrupt counter (may be needed to assure correct order
- *                  in multithreaded drivers)
+ *         in multithreaded drivers)
  *
  * Note on synchronization for ipc_irq_register(), ipc_irq_unregister(),
@@ -131 +130 @@
 /** Register an answerbox as a receiving end for IRQ notifications.
  *
- * @param box           Receiving answerbox.
- * @param inr           IRQ number.
- * @param devno         Device number.
- * @param imethod       Interface and method to be associated with the
- *                      notification.
- * @param ucode         Uspace pointer to top-half pseudocode.
- * @return              EOK on success or a negative error code.
+ * @param box    Receiving answerbox.
+ * @param inr    IRQ number.
+ * @param devno  Device number.
+ * @param method Method to be associated with the notification.
+ * @param ucode  Uspace pointer to top-half pseudocode.
+ *
+ * @return EBADMEM, ENOENT or EEXISTS on failure or 0 on success.
  *
  */
 int ipc_irq_register(answerbox_t *box, inr_t inr, devno_t devno,
-    sysarg_t imethod, irq_code_t *ucode)
-{
-        sysarg_t key[] = {
-                (sysarg_t) inr,
-                (sysarg_t) devno
+    unative_t method, irq_code_t *ucode)
+{
+        unative_t key[] = {
+                (unative_t) inr,
+                (unative_t) devno
         };
-
-        if ((inr < 0) || (inr > last_inr))
-                return ELIMIT;
         
         irq_code_t *code;
@@ -171 +167 @@
         irq->notif_cfg.notify = true;
         irq->notif_cfg.answerbox = box;
-        irq->notif_cfg.imethod = imethod;
+        irq->notif_cfg.method = method;
         irq->notif_cfg.code = code;
         irq->notif_cfg.counter = 0;
@@ -210 +206 @@
 /** Unregister task from IRQ notification.
  *
- * @param box           Answerbox associated with the notification.
- * @param inr           IRQ number.
- * @param devno         Device number.
- * @return              EOK on success or a negative error code.
+ * @param box   Answerbox associated with the notification.
+ * @param inr   IRQ number.
+ * @param devno Device number.
+ *
  */
 int ipc_irq_unregister(answerbox_t *box, inr_t inr, devno_t devno)
 {
-        sysarg_t key[] = {
-                (sysarg_t) inr,
-                (sysarg_t) devno
+        unative_t key[] = {
+                (unative_t) inr,
+                (unative_t) devno
         };
-
-        if ((inr < 0) || (inr > last_inr))
-                return ELIMIT;
         
         irq_spinlock_lock(&irq_uspace_hash_table_lock, true);
@@ -297 +290 @@
                 }
                 
-                sysarg_t key[2];
+                unative_t key[2];
                 key[0] = irq->inr;
                 key[1] = irq->devno;
@@ -404 +397 @@
                             (uint32_t) code->cmds[i].value);
                         break;
-                case CMD_PIO_WRITE_A_8:
-                        if (srcarg) {
-                                pio_write_8((ioport8_t *) code->cmds[i].addr,
-                                    (uint8_t) scratch[srcarg]);
-                        }
-                        break;
-                case CMD_PIO_WRITE_A_16:
-                        if (srcarg) {
-                                pio_write_16((ioport16_t *) code->cmds[i].addr,
-                                    (uint16_t) scratch[srcarg]);
-                        }
-                        break;
-                case CMD_PIO_WRITE_A_32:
-                        if (srcarg) {
-                                pio_write_32((ioport32_t *) code->cmds[i].addr,
-                                    (uint32_t) scratch[srcarg]);
-                        }
-                        break;
                 case CMD_BTEST:
                         if ((srcarg) && (dstarg)) {
@@ -469 +444 @@
                 
                 /* Set up args */
-                IPC_SET_IMETHOD(call->data, irq->notif_cfg.imethod);
+                IPC_SET_METHOD(call->data, irq->notif_cfg.method);
                 IPC_SET_ARG1(call->data, irq->notif_cfg.scratch[1]);
                 IPC_SET_ARG2(call->data, irq->notif_cfg.scratch[2]);
@@ -490 +465 @@
  *
  */
-void ipc_irq_send_msg(irq_t *irq, sysarg_t a1, sysarg_t a2, sysarg_t a3,
-    sysarg_t a4, sysarg_t a5)
+void ipc_irq_send_msg(irq_t *irq, unative_t a1, unative_t a2, unative_t a3,
+    unative_t a4, unative_t a5)
 {
         irq_spinlock_lock(&irq->lock, true);
@@ -506 +481 @@
                 call->priv = ++irq->notif_cfg.counter;
                 
-                IPC_SET_IMETHOD(call->data, irq->notif_cfg.imethod);
+                IPC_SET_METHOD(call->data, irq->notif_cfg.method);
                 IPC_SET_ARG1(call->data, a1);
                 IPC_SET_ARG2(call->data, a2);