Changes in uspace/lib/usbhid/src/hidparser.c [9d58539:1e371cf] in mainline

File:

• uspace/lib/usbhid/src/hidparser.c (modified) (21 diffs)

uspace/lib/usbhid/src/hidparser.c

@@ -41 +41 @@
 #include <assert.h>
 
-/*---------------------------------------------------------------------------*/
+
 /*
  * Data translation private functions
@@ -52 +52 @@
         int32_t value);
 
-/*---------------------------------------------------------------------------*/
+
 
 static int usb_pow(int a, int b)
@@ -68 +68 @@
         }
 }
-/*---------------------------------------------------------------------------*/
+
 
 /** Returns size of report of specified report id and type in items
@@ -117 +117 @@
         }
 }
-/*---------------------------------------------------------------------------*/
+
 
 /** Parse and act upon a HID report.
@@ -130 +130 @@
     size_t size, uint8_t *report_id)
 {
-        usb_hid_report_field_t *item;
-
         usb_hid_report_description_t *report_des;
         usb_hid_report_type_t type = USB_HID_REPORT_TYPE_INPUT;
@@ -153 +151 @@
 
         /* read data */
-        list_foreach(report_des->report_items, list_item) {
-                item = list_get_instance(list_item, usb_hid_report_field_t, 
-                    ritems_link);
+        list_foreach(report_des->report_items, ritems_link,
+            usb_hid_report_field_t, item) {
 
                 if (USB_HID_ITEM_FLAG_CONSTANT(item->item_flags) == 0) {
@@ -163 +160 @@
                                 item->value = 
                                         usb_hid_translate_data(item, data);
-                
+                                
                                 item->usage = USB_HID_EXTENDED_USAGE(
                                     item->usages[item->value -
@@ -184 +181 @@
                                 /* variable item */
                                 item->value = usb_hid_translate_data(item, 
-                                    data);                              
-                        }                       
+                                    data);
+                        }
                 }
         }
@@ -192 +189 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Translate data from the report as specified in report descriptor item
@@ -274 +271 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /* OUTPUT API */
 
@@ -295 +292 @@
         usb_hid_report_description_t *report_des = NULL;
 
-        list_foreach(report->reports, report_it) {
-                report_des = list_get_instance(report_it,
-                    usb_hid_report_description_t, reports_link);
-                
-                if ((report_des->report_id == report_id) &&
-                    (report_des->type == USB_HID_REPORT_TYPE_OUTPUT)) {
+        list_foreach(report->reports, reports_link,
+            usb_hid_report_description_t, rdes) {
+                if ((rdes->report_id == report_id) &&
+                    (rdes->type == USB_HID_REPORT_TYPE_OUTPUT)) {
+                        report_des = rdes;
                         break;
                 }
@@ -351 +347 @@
 
         if (report->use_report_ids != 0) {
-                buffer[0] = report_id;          
+                buffer[0] = report_id;
         }
 
@@ -362 +358 @@
         }
 
-        usb_hid_report_field_t *report_item;
-
-        list_foreach(report_des->report_items, item) {
-                report_item = list_get_instance(item, usb_hid_report_field_t,
-                    ritems_link);
-
+        list_foreach(report_des->report_items, ritems_link,
+            usb_hid_report_field_t, report_item) {
                 value = usb_hid_translate_data_reverse(report_item, 
                     report_item->value);
@@ -382 +374 @@
                         }
                         size_t shift = 8 - offset % 8 - length;
-                        value = value << shift;                                                 
+                        value = value << shift;
                         value = value & (((1 << length) - 1) << shift);
-                                
+                        
                         uint8_t mask = 0;
                         mask = 0xff - (((1 << length) - 1) << shift);
@@ -400 +392 @@
 
                                         tmp_value = tmp_value << (offset % 8);
-        
+                                        
                                         mask = ~(((1 << (8 - (offset % 8))) - 1)
                                             << (offset % 8));
@@ -413 +405 @@
                                         value = value & ((1 << (length - 
                                             ((offset + length) % 8))) - 1);
-                                
+                                        
                                         mask = (1 << (length - 
                                             ((offset + length) % 8))) - 1;
@@ -431 +423 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Translate given data for putting them into the outoput report
@@ -476 +468 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Clones given state table
@@ -497 +489 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Function for sequence walking through the report. Returns next field in the
@@ -552 +544 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Returns next report_id of report of specified type. If zero is given than
@@ -600 +592 @@
 }
 
-/*---------------------------------------------------------------------------*/
+
 /**
  * Reset all local items in given state table