Changes in uspace/lib/c/generic/task.c [3815efb:1e9f8ab] in mainline

File:

• uspace/lib/c/generic/task.c (modified) (12 diffs)

uspace/lib/c/generic/task.c

@@ -35 +35 @@
 
 #include <task.h>
+#include <libc.h>
+#include <stdlib.h>
+#include <errno.h>
 #include <loader/loader.h>
 #include <stdarg.h>
@@ -40 +43 @@
 #include <ipc/ns.h>
 #include <macros.h>
-#include <assert.h>
 #include <async.h>
-#include <errno.h>
-#include <malloc.h>
-#include <libc.h>
-#include "private/ns.h"
 
 task_id_t task_get_id(void)
@@ -70 +68 @@
 int task_set_name(const char *name)
 {
-        assert(name);
-        
         return __SYSCALL2(SYS_TASK_SET_NAME, (sysarg_t) name, str_size(name));
 }
@@ -92 +88 @@
  * loader API. Arguments are passed as a null-terminated array of strings.
  *
- * @param id   If not NULL, the ID of the task is stored here on success.
- * @param path Pathname of the binary to execute.
- * @param argv Command-line arguments.
- *
- * @return Zero on success or negative error code.
- *
+ * @param id    If not NULL, the ID of the task is stored here on success.
+ * @param path  Pathname of the binary to execute.
+ * @param argv  Command-line arguments.
+ *
+ * @return      Zero on success or negative error code.
  */
 int task_spawnv(task_id_t *id, const char *path, const char *const args[])
 {
+        loader_t *ldr;
+        task_id_t task_id;
+        int rc;
+
+        /* Connect to a program loader. */
+        ldr = loader_connect();
+        if (ldr == NULL)
+                return EREFUSED;
+        
+        /* Get task ID. */
+        rc = loader_get_task_id(ldr, &task_id);
+        if (rc != EOK)
+                goto error;
+        
+        /* Send spawner's current working directory. */
+        rc = loader_set_cwd(ldr);
+        if (rc != EOK)
+                goto error;
+        
+        /* Send program pathname. */
+        rc = loader_set_pathname(ldr, path);
+        if (rc != EOK)
+                goto error;
+        
+        /* Send arguments. */
+        rc = loader_set_args(ldr, args);
+        if (rc != EOK)
+                goto error;
+        
         /* Send default files */
         fdi_node_t *files[4];
@@ -124 +148 @@
         files[3] = NULL;
         
-        return task_spawnvf(id, path, args, files);
-}
-
-/** Create a new task by running an executable from the filesystem.
- *
- * This is really just a convenience wrapper over the more complicated
- * loader API. Arguments are passed as a null-terminated array of strings.
- * Files are passed as null-terminated array of pointers to fdi_node_t.
- *
- * @param id    If not NULL, the ID of the task is stored here on success.
- * @param path  Pathname of the binary to execute.
- * @param argv  Command-line arguments.
- * @param files Standard files to use.
- *
- * @return Zero on success or negative error code.
- *
- */
-int task_spawnvf(task_id_t *id, const char *path, const char *const args[],
-    fdi_node_t *const files[])
-{
-        /* Connect to a program loader. */
-        loader_t *ldr = loader_connect();
-        if (ldr == NULL)
-                return EREFUSED;
-        
-        /* Get task ID. */
-        task_id_t task_id;
-        int rc = loader_get_task_id(ldr, &task_id);
-        if (rc != EOK)
-                goto error;
-        
-        /* Send spawner's current working directory. */
-        rc = loader_set_cwd(ldr);
-        if (rc != EOK)
-                goto error;
-        
-        /* Send program pathname. */
-        rc = loader_set_pathname(ldr, path);
-        if (rc != EOK)
-                goto error;
-        
-        /* Send arguments. */
-        rc = loader_set_args(ldr, args);
-        if (rc != EOK)
-                goto error;
-        
-        /* Send files */
         rc = loader_set_files(ldr, files);
         if (rc != EOK)
@@ -186 +163 @@
         
         /* Success */
+        free(ldr);
+        
         if (id != NULL)
                 *id = task_id;
@@ -194 +173 @@
         /* Error exit */
         loader_abort(ldr);
+        free(ldr);
         return rc;
 }
@@ -202 +182 @@
  * loader API. Arguments are passed as a null-terminated list of arguments.
  *
- * @param id   If not NULL, the ID of the task is stored here on success.
- * @param path Pathname of the binary to execute.
- * @param ...  Command-line arguments.
- *
- * @return Zero on success or negative error code.
- *
+ * @param id    If not NULL, the ID of the task is stored here on success.
+ * @param path  Pathname of the binary to execute.
+ * @param ...   Command-line arguments.
+ *
+ * @return      Zero on success or negative error code.
  */
 int task_spawnl(task_id_t *task_id, const char *path, ...)
 {
-        /* Count the number of arguments. */
-        
         va_list ap;
+        int rc, cnt;
         const char *arg;
         const char **arglist;
-        int cnt = 0;
-        
+
+        /* Count the number of arguments. */
+        cnt = 0;
         va_start(ap, path);
         do {
@@ -224 +203 @@
         } while (arg != NULL);
         va_end(ap);
-        
+
         /* Allocate argument list. */
         arglist = malloc(cnt * sizeof(const char *));
         if (arglist == NULL)
                 return ENOMEM;
-        
+
         /* Fill in arguments. */
         cnt = 0;
@@ -238 +217 @@
         } while (arg != NULL);
         va_end(ap);
-        
+
         /* Spawn task. */
-        int rc = task_spawnv(task_id, path, arglist);
-        
+        rc = task_spawnv(task_id, path, arglist);
+
         /* Free argument list. */
         free(arglist);
@@ -249 +228 @@
 int task_wait(task_id_t id, task_exit_t *texit, int *retval)
 {
-        assert(texit);
-        assert(retval);
-        
-        async_exch_t *exch = async_exchange_begin(session_ns);
         sysarg_t te, rv;
-        int rc = (int) async_req_2_2(exch, NS_TASK_WAIT, LOWER32(id),
+        int rc;
+
+        rc = (int) async_req_2_2(PHONE_NS, NS_TASK_WAIT, LOWER32(id),
             UPPER32(id), &te, &rv);
-        async_exchange_end(exch);
-        
         *texit = te;
         *retval = rv;
-        
+
         return rc;
 }
@@ -266 +241 @@
 int task_retval(int val)
 {
-        async_exch_t *exch = async_exchange_begin(session_ns);
-        int rc = (int) async_req_1_0(exch, NS_RETVAL, val);
-        async_exchange_end(exch);
-        
-        return rc;
+        return (int) async_req_1_0(PHONE_NS, NS_RETVAL, val);
 }