Changeset 241ab7e in mainline

Timestamp:

2021-08-08T22:34:38Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

edeee9f

Parents:

2177b39

Message:

Declare buffer as uint8_t * for stricter type checking

Location:

uspace/lib/inet

Files:

• include/inet/eth_addr.h (modified) (1 diff)
• src/eth_addr.c (modified) (4 diffs)

uspace/lib/inet/include/inet/eth_addr.h

@@ -74 +74 @@
 extern const eth_addr_t eth_addr_broadcast;
 
-extern void eth_addr_encode(eth_addr_t *, void *);
-extern void eth_addr_decode(const void *, eth_addr_t *);
+extern void eth_addr_encode(eth_addr_t *, uint8_t *);
+extern void eth_addr_decode(const uint8_t *, eth_addr_t *);
 
 extern int eth_addr_compare(const eth_addr_t *, const eth_addr_t *);

uspace/lib/inet/src/eth_addr.c

@@ -50 +50 @@
  * @param buf Buffer (ETH_ADDR_SIZE bytes in size) to store bytes
  */
-void eth_addr_encode(eth_addr_t *addr, void *buf)
+void eth_addr_encode(eth_addr_t *addr, uint8_t *buf)
 {
-        uint8_t *bp = (uint8_t *)buf;
         uint64_t a;
         int i;
@@ -59 +58 @@
 
         for (i = 0; i < ETH_ADDR_SIZE; i++)
-                bp[i] = (a >> (40 - 8 * i)) & 0xff;
+                buf[i] = (a >> (40 - 8 * i)) & 0xff;
 }
 
@@ -70 +69 @@
  * @param addr Place to store Ethernet address
  */
-void eth_addr_decode(const void *buf, eth_addr_t *addr)
+void eth_addr_decode(const uint8_t *buf, eth_addr_t *addr)
 {
-        const uint8_t *bp = (uint8_t *)buf;
         uint64_t a;
         int i;
@@ -78 +76 @@
         a = 0;
         for (i = 0; i < ETH_ADDR_SIZE; i++)
-                a |= (uint64_t)bp[i] << (40 - 8 * i);
+                a |= (uint64_t)buf[i] << (40 - 8 * i);
 
         addr->a = a;