Changeset 257ceb1 in mainline

Timestamp:

2010-07-16T09:06:56Z (15 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63bdde6

Parents:

f77e591d

Message:

Introduce the stack trace context which is passed to the individual stack
tracing hooks and which can carry some additional information.

Location:

kernel/generic

Files:

• include/stacktrace.h (modified) (3 diffs)
• src/debug/stacktrace.c (modified) (6 diffs)

kernel/generic/include/stacktrace.h

@@ -42 +42 @@
 
 typedef struct {
-        bool (* frame_pointer_validate)(uintptr_t);
-        bool (* frame_pointer_prev)(uintptr_t, uintptr_t *);
-        bool (* return_address_get)(uintptr_t, uintptr_t *);
+        uintptr_t fp;
+        uintptr_t pc;
+        struct istate *istate;
+} stack_trace_context_t;
+
+typedef struct {
+        bool (* stack_trace_context_validate)(stack_trace_context_t *);
+        bool (* frame_pointer_prev)(stack_trace_context_t *, uintptr_t *);
+        bool (* return_address_get)(stack_trace_context_t *, uintptr_t *);
         bool (* symbol_resolve)(uintptr_t, const char **, uintptr_t *);
 } stack_trace_ops_t;
@@ -53 +59 @@
 extern void stack_trace(void);
 extern void stack_trace_istate(struct istate *);
-extern void stack_trace_fp_pc(stack_trace_ops_t *, uintptr_t, uintptr_t);
+extern void stack_trace_ctx(stack_trace_ops_t *, stack_trace_context_t *);
 
 /*
@@ -61 +67 @@
 extern uintptr_t program_counter_get(void);
 
-extern bool kernel_frame_pointer_validate(uintptr_t);
-extern bool kernel_frame_pointer_prev(uintptr_t, uintptr_t *);
-extern bool kernel_return_address_get(uintptr_t, uintptr_t *);
+extern bool kernel_stack_trace_context_validate(stack_trace_context_t *);
+extern bool kernel_frame_pointer_prev(stack_trace_context_t *, uintptr_t *);
+extern bool kernel_return_address_get(stack_trace_context_t *, uintptr_t *);
 
-extern bool uspace_frame_pointer_validate(uintptr_t);
-extern bool uspace_frame_pointer_prev(uintptr_t, uintptr_t *);
-extern bool uspace_return_address_get(uintptr_t, uintptr_t *);
+extern bool uspace_stack_trace_context_validate(stack_trace_context_t *);
+extern bool uspace_frame_pointer_prev(stack_trace_context_t *, uintptr_t *);
+extern bool uspace_return_address_get(stack_trace_context_t *, uintptr_t *);
 
 #endif

kernel/generic/src/debug/stacktrace.c

@@ -27 +27 @@
  */
 
-/** @addtogroup genericdebug 
+/** @addtogroup genericdebug
  * @{
  */
@@ -42 +42 @@
 
 void
-stack_trace_fp_pc(stack_trace_ops_t *ops, uintptr_t fp, uintptr_t pc)
+stack_trace_ctx(stack_trace_ops_t *ops, stack_trace_context_t *ctx)
 {
         int cnt = 0;
         const char *symbol;
         uintptr_t offset;
+        uintptr_t fp;
+        uintptr_t pc;
         
-        while (cnt++ < STACK_FRAMES_MAX && ops->frame_pointer_validate(fp)) {
+        while (cnt++ < STACK_FRAMES_MAX &&
+            ops->stack_trace_context_validate(ctx)) {
                 if (ops->symbol_resolve &&
-                    ops->symbol_resolve(pc, &symbol, &offset)) {
+                    ops->symbol_resolve(ctx->pc, &symbol, &offset)) {
                         if (offset)
-                                printf("%p: %s+%" PRIp "()\n", fp, symbol, offset);
+                                printf("%p: %s+%" PRIp "()\n",
+                                    ctx->fp, symbol, offset);
                         else
-                                printf("%p: %s()\n", fp, symbol);
+                                printf("%p: %s()\n",
+                                    ctx->fp, symbol);
                 } else {
-                        printf("%p: %p()\n", fp, pc);
+                        printf("%p: %p()\n", ctx->fp, ctx->pc);
                 }
-                if (!ops->return_address_get(fp, &pc))
+                if (!ops->return_address_get(ctx, &pc))
                         break;
-                if (!ops->frame_pointer_prev(fp, &fp))
+                if (!ops->frame_pointer_prev(ctx, &fp))
                         break;
+                ctx->fp = fp;
+                ctx->pc = pc;
         }
 }
@@ -67 +74 @@
 void stack_trace(void)
 {
-        stack_trace_fp_pc(&kst_ops, frame_pointer_get(), program_counter_get());
+        stack_trace_context_t ctx = {
+                .fp = frame_pointer_get(),
+                .pc = program_counter_get(),
+                .istate = NULL
+        };
+
+        stack_trace_ctx(&kst_ops, &ctx);
 
         /*
@@ -78 +91 @@
 void stack_trace_istate(istate_t *istate)
 {
+        stack_trace_context_t ctx = {
+                .fp = istate_get_fp(istate),
+                .pc = istate_get_pc(istate),
+                .istate = istate
+        };
+        
         if (istate_from_uspace(istate))
-                stack_trace_fp_pc(&ust_ops, istate_get_fp(istate),
-                    istate_get_pc(istate));
+                stack_trace_ctx(&ust_ops, &ctx);
         else
-                stack_trace_fp_pc(&kst_ops, istate_get_fp(istate),
-                    istate_get_pc(istate));
+                stack_trace_ctx(&kst_ops, &ctx);
 }
 
-static bool kernel_symbol_resolve(uintptr_t addr, const char **sp, uintptr_t *op)
+static bool
+kernel_symbol_resolve(uintptr_t addr, const char **sp, uintptr_t *op)
 {
         return (symtab_name_lookup(addr, sp, op) == 0);
@@ -92 +110 @@
 
 stack_trace_ops_t kst_ops = {
-        .frame_pointer_validate = kernel_frame_pointer_validate,
+        .stack_trace_context_validate = kernel_stack_trace_context_validate,
         .frame_pointer_prev = kernel_frame_pointer_prev,
         .return_address_get = kernel_return_address_get,
@@ -99 +117 @@
 
 stack_trace_ops_t ust_ops = {
-        .frame_pointer_validate = uspace_frame_pointer_validate,
+        .stack_trace_context_validate = uspace_stack_trace_context_validate,
         .frame_pointer_prev = uspace_frame_pointer_prev,
         .return_address_get = uspace_return_address_get,