Changes in uspace/app/inet/inet.c [bf9e6fc:257feec] in mainline

File:

• uspace/app/inet/inet.c (modified) (14 diffs)

uspace/app/inet/inet.c

@@ -1 +1 @@
 /*
- * Copyright (c) 2012 Jiri Svoboda
+ * Copyright (c) 2013 Jiri Svoboda
  * All rights reserved.
  *
@@ -36 +36 @@
 
 #include <errno.h>
+#include <inet/addr.h>
 #include <inet/inetcfg.h>
 #include <loc.h>
@@ -43 +44 @@
 #include <sys/types.h>
 
-#define NAME "inet"
+#define NAME  "inet"
 
 static void print_syntax(void)
@@ -54 +55 @@
 }
 
-static int naddr_parse(const char *text, inet_naddr_t *naddr)
-{
-        unsigned long a[4], bits;
-        char *cp = (char *)text;
-        int i;
-
-        for (i = 0; i < 3; i++) {
-                a[i] = strtoul(cp, &cp, 10);
-                if (*cp != '.')
-                        return EINVAL;
-                ++cp;
-        }
-
-        a[3] = strtoul(cp, &cp, 10);
-        if (*cp != '/')
-                return EINVAL;
-        ++cp;
-
-        bits = strtoul(cp, &cp, 10);
-        if (*cp != '\0')
-                return EINVAL;
-
-        naddr->ipv4 = 0;
-        for (i = 0; i < 4; i++) {
-                if (a[i] > 255)
-                        return EINVAL;
-                naddr->ipv4 = (naddr->ipv4 << 8) | a[i];
-        }
-
-        if (bits > 31)
-                return EINVAL;
-
-        naddr->bits = bits;
-        return EOK;
-}
-
-static int addr_parse(const char *text, inet_addr_t *addr)
-{
-        unsigned long a[4];
-        char *cp = (char *)text;
-        int i;
-
-        for (i = 0; i < 3; i++) {
-                a[i] = strtoul(cp, &cp, 10);
-                if (*cp != '.')
-                        return EINVAL;
-                ++cp;
-        }
-
-        a[3] = strtoul(cp, &cp, 10);
-        if (*cp != '\0')
-                return EINVAL;
-
-        addr->ipv4 = 0;
-        for (i = 0; i < 4; i++) {
-                if (a[i] > 255)
-                        return EINVAL;
-                addr->ipv4 = (addr->ipv4 << 8) | a[i];
-        }
-
-        return EOK;
-}
-
-static int naddr_format(inet_naddr_t *naddr, char **bufp)
-{
-        int rc;
-
-        rc = asprintf(bufp, "%d.%d.%d.%d/%d", naddr->ipv4 >> 24,
-            (naddr->ipv4 >> 16) & 0xff, (naddr->ipv4 >> 8) & 0xff,
-            naddr->ipv4 & 0xff, naddr->bits);
-
-        if (rc < 0)
-                return ENOMEM;
-
-        return EOK;
-}
-
-static int addr_format(inet_addr_t *addr, char **bufp)
-{
-        int rc;
-
-        rc = asprintf(bufp, "%d.%d.%d.%d", addr->ipv4 >> 24,
-            (addr->ipv4 >> 16) & 0xff, (addr->ipv4 >> 8) & 0xff,
-            addr->ipv4 & 0xff);
-
-        if (rc < 0)
-                return ENOMEM;
-
-        return EOK;
-}
-
 static int addr_create_static(int argc, char *argv[])
 {
@@ -178 +88 @@
         }
 
-        rc = naddr_parse(addr_spec, &naddr);
+        rc = inet_naddr_parse(addr_spec, &naddr);
         if (rc != EOK) {
                 printf(NAME ": Invalid network address format '%s'.\n",
@@ -267 +177 @@
         route_name = argv[2];
 
-        rc = naddr_parse(dest_str, &dest);
+        rc = inet_naddr_parse(dest_str, &dest);
         if (rc != EOK) {
                 printf(NAME ": Invalid network address format '%s'.\n",
@@ -274 +184 @@
         }
 
-        rc = addr_parse(router_str, &router);
+        rc = inet_addr_parse(router_str, &router);
         if (rc != EOK) {
                 printf(NAME ": Invalid address format '%s'.\n", router_str);
@@ -347 +257 @@
         if (count > 0)
                 printf("    [Addr/Width] [Link-Name] [Addr-Name] [Def-MTU]\n");
-        ainfo.name = linfo.name = astr = NULL;
+        ainfo.name = NULL;
+        linfo.name = NULL;
+        astr = NULL;
 
         for (i = 0; i < count; i++) {
@@ -366 +278 @@
                 }
 
-                rc = naddr_format(&ainfo.naddr, &astr);
+                rc = inet_naddr_format(&ainfo.naddr, &astr);
                 if (rc != EOK) {
                         printf("Memory allocation failed.\n");
@@ -380 +292 @@
                 free(astr);
 
-                ainfo.name = linfo.name = astr = NULL;
+                ainfo.name = NULL;
+                linfo.name = NULL;
+                astr = NULL;
         }
 
@@ -419 +333 @@
                 printf("    [Dest/Width] [Router-Addr] [Route-Name]\n");
 
-        srinfo.name = dest_str = router_str = NULL;
+        srinfo.name = NULL;
+        dest_str = NULL;
+        router_str = NULL;
 
         for (i = 0; i < count; i++) {
@@ -430 +346 @@
                 }
 
-                rc = naddr_format(&srinfo.dest, &dest_str);
+                rc = inet_naddr_format(&srinfo.dest, &dest_str);
                 if (rc != EOK) {
                         printf("Memory allocation failed.\n");
@@ -437 +353 @@
                 }
 
-                rc = addr_format(&srinfo.router, &router_str);
+                rc = inet_addr_format(&srinfo.router, &router_str);
                 if (rc != EOK) {
                         printf("Memory allocation failed.\n");
@@ -450 +366 @@
                 free(router_str);
 
-                router_str = srinfo.name = dest_str = NULL;
+                router_str = NULL;
+                srinfo.name = NULL;
+                dest_str = NULL;
         }