Changeset 2721a75 in mainline for uspace/app/netecho/netecho.c

Timestamp:

2010-04-09T16:29:07Z (15 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1ef0fc3

Parents:

ddfcfeb2

Message:

ping overhaul:

• coding style
• shorter and better readable main()
• tool output is much similar to GNU's ping, demonstrating what functionality is still missing

related changes:

• rename strerror.h → str_error.h for consistency
• replace network apps' specific command-line parsing functions with a generalized libc versions

File:

• uspace/app/netecho/netecho.c (modified) (6 diffs)

uspace/app/netecho/netecho.c

@@ -40 +40 @@
 #include <str.h>
 #include <task.h>
+#include <arg_parse.h>
 
 #include <in.h>
@@ -46 +47 @@
 #include <socket.h>
 #include <net_err.h>
-
-#include "parse.h"
+#include <socket_parse.h>
+
 #include "print_error.h"
 
@@ -133 +134 @@
                         switch(argv[index][1]){
                                 case 'b':
-                                        ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &backlog, "accepted sockets queue size", 0));
+                                        ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &backlog, 0));
                                         break;
                                 case 'c':
-                                        ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &count, "message count", 0));
+                                        ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &count, 0));
                                         break;
                                 case 'f':
-                                        ERROR_PROPAGATE(parse_parameter_name_int(argc, argv, &index, &family, "protocol family", 0, parse_protocol_family));
+                                        ERROR_PROPAGATE(arg_parse_name_int(argc, argv, &index, &family, 0, socket_parse_protocol_family));
                                         break;
                                 case 'h':
@@ -146 +147 @@
                                         break;
                                 case 'p':
-                                        ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &value, "port number", 0));
+                                        ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &value, 0));
                                         port = (uint16_t) value;
                                         break;
                                 case 'r':
-                                        ERROR_PROPAGATE(parse_parameter_string(argc, argv, &index, &reply, "reply string", 0));
+                                        ERROR_PROPAGATE(arg_parse_string(argc, argv, &index, &reply, 0));
                                         break;
                                 case 's':
-                                        ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &value, "receive size", 0));
+                                        ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &value, 0));
                                         size = (value >= 0) ? (size_t) value : 0;
                                         break;
                                 case 't':
-                                        ERROR_PROPAGATE(parse_parameter_name_int(argc, argv, &index, &value, "socket type", 0, parse_socket_type));
+                                        ERROR_PROPAGATE(arg_parse_name_int(argc, argv, &index, &value, 0, socket_parse_socket_type));
                                         type = (sock_type_t) value;
                                         break;
@@ -166 +167 @@
                                 case '-':
                                         if(str_lcmp(argv[index] + 2, "backlog=", 6) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &backlog, "accepted sockets queue size", 8));
+                                                ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &backlog, 8));
                                         }else if(str_lcmp(argv[index] + 2, "count=", 6) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &count, "message count", 8));
+                                                ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &count, 8));
                                         }else if(str_lcmp(argv[index] + 2, "family=", 7) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_name_int(argc, argv, &index, &family, "protocol family", 9, parse_protocol_family));
+                                                ERROR_PROPAGATE(arg_parse_name_int(argc, argv, &index, &family, 9, socket_parse_protocol_family));
                                         }else if(str_lcmp(argv[index] + 2, "help", 5) == 0){
                                                 echo_print_help();
                                                 return EOK;
                                         }else if(str_lcmp(argv[index] + 2, "port=", 5) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &value, "port number", 7));
+                                                ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &value, 7));
                                                 port = (uint16_t) value;
                                         }else if(str_lcmp(argv[index] + 2, "reply=", 6) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_string(argc, argv, &index, &reply, "reply string", 8));
+                                                ERROR_PROPAGATE(arg_parse_string(argc, argv, &index, &reply, 8));
                                         }else if(str_lcmp(argv[index] + 2, "size=", 5) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_int(argc, argv, &index, &value, "receive size", 7));
+                                                ERROR_PROPAGATE(arg_parse_int(argc, argv, &index, &value, 7));
                                                 size = (value >= 0) ? (size_t) value : 0;
                                         }else if(str_lcmp(argv[index] + 2, "type=", 5) == 0){
-                                                ERROR_PROPAGATE(parse_parameter_name_int(argc, argv, &index, &value, "socket type", 7, parse_socket_type));
+                                                ERROR_PROPAGATE(arg_parse_name_int(argc, argv, &index, &value, 7, socket_parse_socket_type));
                                                 type = (sock_type_t) value;
                                         }else if(str_lcmp(argv[index] + 2, "verbose", 8) == 0){
                                                 verbose = 1;
                                         }else{
-                                                print_unrecognized(index, argv[index] + 2);
                                                 echo_print_help();
                                                 return EINVAL;
@@ -194 +194 @@
                                         break;
                                 default:
-                                        print_unrecognized(index, argv[index] + 1);
                                         echo_print_help();
                                         return EINVAL;
                         }
                 }else{
-                        print_unrecognized(index, argv[index]);
                         echo_print_help();
                         return EINVAL;