Changes in uspace/drv/uhci-rhd/main.c [f123909:275bf456] in mainline

File:

• uspace/drv/uhci-rhd/main.c (modified) (6 diffs)

uspace/drv/uhci-rhd/main.c

@@ -26 +26 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
-/** @addtogroup drvusbuhcirh
+/** @addtogroup usb
  * @{
  */
 /** @file
- * @brief UHCI root hub initialization routines
+ * @brief UHCI driver
  */
 #include <ddf/driver.h>
@@ -40 +40 @@
 #include <usb/debug.h>
 
+
+
 #include "root_hub.h"
 
@@ -45 +47 @@
 static int hc_get_my_registers(ddf_dev_t *dev,
     uintptr_t *io_reg_address, size_t *io_reg_size);
-#if 0
 /*----------------------------------------------------------------------------*/
 static int usb_iface_get_hc_handle(ddf_fun_t *fun, devman_handle_t *handle)
@@ -66 +67 @@
         .interfaces[USB_DEV_IFACE] = &uhci_rh_usb_iface,
 };
-#endif
 /*----------------------------------------------------------------------------*/
-/** Initialize a new ddf driver instance of UHCI root hub.
+/** Initializes a new ddf driver instance of UHCI root hub.
  *
  * @param[in] device DDF instance of the device to initialize.
@@ -81 +81 @@
 
         //device->ops = &uhci_rh_ops;
+        (void) uhci_rh_ops;
+
+        uhci_root_hub_t *rh = malloc(sizeof(uhci_root_hub_t));
+        if (!rh) {
+                usb_log_error("Failed to allocate memory for driver instance.\n");
+                return ENOMEM;
+        }
+
         uintptr_t io_regs = 0;
         size_t io_size = 0;
 
         int ret = hc_get_my_registers(device, &io_regs, &io_size);
-        if (ret != EOK) {
-                usb_log_error("Failed(%d) to get registers from parent hc.",
-                    ret);
-        }
-        usb_log_info("I/O regs at %#X (size %zu).\n", io_regs, io_size);
+        assert(ret == EOK);
 
-        uhci_root_hub_t *rh = malloc(sizeof(uhci_root_hub_t));
-        if (!rh) {
-                usb_log_error("Failed to allocate driver instance.\n");
-                return ENOMEM;
-        }
-
+        /* TODO: verify values from hc */
+        usb_log_info("I/O regs at 0x%X (size %zu).\n", io_regs, io_size);
         ret = uhci_root_hub_init(rh, (void*)io_regs, io_size, device);
         if (ret != EOK) {
@@ -119 +119 @@
 };
 /*----------------------------------------------------------------------------*/
-/** Initialize global driver structures (NONE).
+/** Initializes global driver structures (NONE).
  *
  * @param[in] argc Nmber of arguments in argv vector (ignored).