Changes in uspace/app/trace/trace.c [79ae36dd:28a3e74] in mainline

File:

• uspace/app/trace/trace.c (modified) (21 diffs)

uspace/app/trace/trace.c

@@ -72 +72 @@
 ipc_call_t thread_ipc_req[THBUF_SIZE];
 
-async_sess_t *sess;
+int phoneid;
 bool abort_trace;
 
@@ -81 +81 @@
 
 static bool cev_valid;
-static kbd_event_t cev;
+static console_event_t cev;
 
 void thread_trace_start(uintptr_t thread_hash);
@@ -146 +146 @@
 static int connect_task(task_id_t task_id)
 {
-        async_sess_t *ksess = async_connect_kbox(task_id);
-        
-        if (!ksess) {
-                if (errno == ENOTSUP) {
-                        printf("You do not have userspace debugging support "
-                            "compiled in the kernel.\n");
-                        printf("Compile kernel with 'Support for userspace debuggers' "
-                            "(CONFIG_UDEBUG) enabled.\n");
-                        return errno;
-                }
-                
+        int rc;
+
+        rc = async_connect_kbox(task_id);
+
+        if (rc == ENOTSUP) {
+                printf("You do not have userspace debugging support "
+                    "compiled in the kernel.\n");
+                printf("Compile kernel with 'Support for userspace debuggers' "
+                    "(CONFIG_UDEBUG) enabled.\n");
+                return rc;
+        }
+
+        if (rc < 0) {
                 printf("Error connecting\n");
-                printf("ipc_connect_task(%" PRIu64 ") -> %d ", task_id, errno);
-                return errno;
-        }
-        
-        int rc = udebug_begin(ksess);
+                printf("ipc_connect_task(%" PRIu64 ") -> %d ", task_id, rc);
+                return rc;
+        }
+
+        phoneid = rc;
+
+        rc = udebug_begin(phoneid);
         if (rc < 0) {
                 printf("udebug_begin() -> %d\n", rc);
                 return rc;
         }
-        
-        rc = udebug_set_evmask(ksess, UDEBUG_EM_ALL);
+
+        rc = udebug_set_evmask(phoneid, UDEBUG_EM_ALL);
         if (rc < 0) {
                 printf("udebug_set_evmask(0x%x) -> %d\n ", UDEBUG_EM_ALL, rc);
                 return rc;
         }
-        
-        sess = ksess;
+
         return 0;
 }
@@ -185 +188 @@
         int i;
 
-        rc = udebug_thread_read(sess, thread_hash_buf,
+        rc = udebug_thread_read(phoneid, thread_hash_buf,
                 THBUF_SIZE*sizeof(unsigned), &tb_copied, &tb_needed);
         if (rc < 0) {
@@ -311 +314 @@
 
         memset(&call, 0, sizeof(call));
-        rc = udebug_mem_read(sess, &call.args, sc_args[1], sizeof(call.args));
+        rc = udebug_mem_read(phoneid, &call.args, sc_args[1], sizeof(call.args));
 
         if (rc >= 0) {
@@ -322 +325 @@
         ipc_call_t question, reply;
         int rc;
-        int phoneid;
-
-        phoneid = sc_args[0];
+        int phoneidx;
+
+//      printf("sc_ipc_call_sync_fast()\n");
+        phoneidx = sc_args[0];
 
         IPC_SET_IMETHOD(question, sc_args[1]);
@@ -333 +337 @@
         IPC_SET_ARG5(question, 0);
 
+//      printf("memset\n");
         memset(&reply, 0, sizeof(reply));
-        rc = udebug_mem_read(sess, &reply.args, sc_args[5], sizeof(reply.args));
-        if (rc < 0)
-                return;
-        
-        ipcp_call_sync(phoneid, &question, &reply);
+//      printf("udebug_mem_read(phone=%d, buffer_ptr=%u, src_addr=%d, n=%d\n",
+//              phoneid, &reply.args, sc_args[5], sizeof(reply.args));
+        rc = udebug_mem_read(phoneid, &reply.args, sc_args[5], sizeof(reply.args));
+//      printf("dmr->%d\n", rc);
+        if (rc < 0) return;
+
+//      printf("call ipc_call_sync\n");
+        ipcp_call_sync(phoneidx, &question, &reply);
 }
 
@@ -347 +355 @@
 
         memset(&question, 0, sizeof(question));
-        rc = udebug_mem_read(sess, &question.args, sc_args[1],
+        rc = udebug_mem_read(phoneid, &question.args, sc_args[1],
             sizeof(question.args));
 
@@ -364 +372 @@
 
         memset(&reply, 0, sizeof(reply));
-        rc = udebug_mem_read(sess, &reply.args, sc_args[2],
+        rc = udebug_mem_read(phoneid, &reply.args, sc_args[2],
             sizeof(reply.args));
 
@@ -383 +391 @@
 
         memset(&call, 0, sizeof(call));
-        rc = udebug_mem_read(sess, &call, sc_args[0], sizeof(call));
-        
-        if (rc >= 0)
+        rc = udebug_mem_read(phoneid, &call, sc_args[0], sizeof(call));
+//      printf("udebug_mem_read(phone %d, dest %d, app-mem src %d, size %d -> %d\n",
+//              phoneid, (int)&call, sc_args[0], sizeof(call), rc);
+
+        if (rc >= 0) {
                 ipcp_call_in(&call, sc_rc);
+        }
 }
 
@@ -396 +407 @@
 
         /* Read syscall arguments */
-        rc = udebug_args_read(sess, thread_hash, sc_args);
+        rc = udebug_args_read(phoneid, thread_hash, sc_args);
+
+        async_serialize_start();
+
+//      printf("[%d] ", thread_id);
 
         if (rc < 0) {
                 printf("error\n");
+                async_serialize_end();
                 return;
         }
@@ -416 +432 @@
                 break;
         }
+
+        async_serialize_end();
 }
 
@@ -426 +444 @@
 
         /* Read syscall arguments */
-        rc = udebug_args_read(sess, thread_hash, sc_args);
+        rc = udebug_args_read(phoneid, thread_hash, sc_args);
+
+        async_serialize_start();
 
 //      printf("[%d] ", thread_id);
@@ -432 +452 @@
         if (rc < 0) {
                 printf("error\n");
+                async_serialize_end();
                 return;
         }
@@ -460 +481 @@
                 break;
         }
+
+        async_serialize_end();
 }
 
 static void event_thread_b(uintptr_t hash)
 {
+        async_serialize_start();
         printf("New thread, hash %p\n", (void *) hash);
+        async_serialize_end();
+
         thread_trace_start(hash);
 }
@@ -501 +527 @@
 
                 /* Run thread until an event occurs */
-                rc = udebug_go(sess, thread_hash,
+                rc = udebug_go(phoneid, thread_hash,
                     &ev_type, &val0, &val1);
 
@@ -630 +656 @@
 {
         (void) arg;
-        
-        console_ctrl_t *console = console_init(stdin, stdout);
-        
+
         while (true) {
                 fibril_mutex_lock(&state_lock);
@@ -638 +662 @@
                         fibril_condvar_wait(&state_cv, &state_lock);
                 fibril_mutex_unlock(&state_lock);
-                
-                if (!console_get_kbd_event(console, &cev))
+
+                if (!console_get_event(fphone(stdin), &cev))
                         return -1;
-                
+
                 fibril_mutex_lock(&state_lock);
                 cev_valid = true;
                 fibril_condvar_broadcast(&state_cv);
-                fibril_mutex_unlock(&state_lock);
+                fibril_mutex_unlock(&state_lock);               
         }
 }
@@ -651 +675 @@
 static void trace_task(task_id_t task_id)
 {
-        kbd_event_t ev;
+        console_event_t ev;
         bool done;
         int i;
@@ -703 +727 @@
                 case KC_P:
                         printf("Pause...\n");
-                        rc = udebug_stop(sess, thash);
+                        rc = udebug_stop(phoneid, thash);
                         if (rc != EOK)
                                 printf("Error: stop -> %d\n", rc);
@@ -719 +743 @@
         printf("\nTerminate debugging session...\n");
         abort_trace = true;
-        udebug_end(sess);
-        async_hangup(sess);
+        udebug_end(phoneid);
+        async_hangup(phoneid);
 
         ipcp_cleanup();