Changeset 2a0b1dd in mainline

Timestamp:

2011-07-11T14:21:58Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

03e3029

Parents:

b7c2757

Message:

OHCI: Root hub: Use named flags instead of numbers.

File:

• uspace/drv/bus/usb/ohci/root_hub.c (modified) (2 diffs)

uspace/drv/bus/usb/ohci/root_hub.c

@@ -420 +420 @@
 /*----------------------------------------------------------------------------*/
 /**
- * Create answer to port status_request.
+ * Create answer to hub status_request.
  *
  * This copies flags in hub status register into the buffer. The format of the
@@ -436 +436 @@
         assert(request);
 
-        /* bits, 0,1,16,17 -- TODO: What do they mean?? Why not 0x0303 */
-        const uint32_t mask = 1 | (1 << 1) | (1 << 16) | (1 << 17);
-        const uint32_t data = mask & instance->registers->rh_status;
+        const uint32_t data = instance->registers->rh_status &
+            (RHS_LPS_FLAG | RHS_LPSC_FLAG | RHS_OCI_FLAG | RHS_OCIC_FLAG);
         memcpy(request->data_buffer, &data, 4);
         request->transfered_size = 4;
-
         return EOK;
 }