Changeset 2a5d4649 in mainline for uspace/drv/block/pci-ide/main.c

Timestamp:

2025-04-14T09:36:33Z (9 days ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master

Children:

11782da

Parents:

6120b7b

git-author:

Jiri Svoboda <jiri@…> (2025-04-14 09:36:30)

git-committer:

Jiri Svoboda <jiri@…> (2025-04-14 09:36:33)

Message:

ISA/PCI IDE needs to attach even if one channel is empty.

File:

• uspace/drv/block/pci-ide/main.c (modified) (2 diffs)

uspace/drv/block/pci-ide/main.c

@@ -136 +136 @@
         pci_ide_hwres_t res;
         async_sess_t *parent_sess;
+        unsigned chans;
         errno_t rc;
 
@@ -157 +158 @@
                 goto error;
 
+        chans = 0;
+
         rc = pci_ide_channel_init(ctrl, &ctrl->channel[0], 0, &res);
-        if (rc == ENOENT)
+        if (rc == EOK)
+                ++chans;
+        else if (rc != ENOENT)
                 goto error;
 
         rc = pci_ide_channel_init(ctrl, &ctrl->channel[1], 1, &res);
-        if (rc == ENOENT)
-                goto error;
-
-        if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed initializing ATA controller.");
+        if (rc == EOK)
+                ++chans;
+        else if (rc != ENOENT)
+                goto error;
+
+        if (chans == 0) {
+                ddf_msg(LVL_ERROR, "No PCI IDE devices found.");
                 rc = EIO;
                 goto error;