Changeset 2aee3e06 in mainline

Timestamp:

2010-12-12T22:08:27Z (14 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

339aeac

Parents:

ecf52c4b

Message:

Minor improvements to virtual USB keyboard

Fixed some formatting + Hungarian constants.

Array of pressed keys is returned only when it differs from
previous status.

File:

• uspace/app/virtusbkbd/virtusbkbd.c (modified) (6 diffs)

uspace/app/virtusbkbd/virtusbkbd.c

@@ -55 +55 @@
 #include "stdreq.h"
 
-#define LOOPS 5
+/** Pause between individual key-presses in seconds. */
+#define KEY_PRESS_DELAY 2
 #define NAME "virt-usb-kbd"
 
@@ -83 +84 @@
 }
 
+/** Compares current and last status of pressed keys.
+ *
+ * @warning Has side-efect - changes status_last field.
+ *
+ * @param status_now Status now.
+ * @param status_last Last status.
+ * @param len Size of status.
+ * @return Whether they are the same.
+ */
+static bool keypress_check_with_last_request(uint8_t *status_now,
+    uint8_t *status_last, size_t len)
+{
+        bool same = true;
+        size_t i;
+        for (i = 0; i < len; i++) {
+                if (status_now[i] != status_last[i]) {
+                        status_last[i] = status_now[i];
+                        same = false;
+                }
+        }
+        return same;
+}
+
 static int on_request_for_data(struct usbvirt_device *dev,
     usb_endpoint_t endpoint, void *buffer, size_t size, size_t *actual_size)
 {
+        static uint8_t last_data[2 + KB_MAX_KEYS_AT_ONCE];
+
         if (size < 2 + KB_MAX_KEYS_AT_ONCE) {
                 return EINVAL;
@@ -101 +127 @@
         }
         
+        if (keypress_check_with_last_request(data, last_data,
+            2 + KB_MAX_KEYS_AT_ONCE)) {
+                *actual_size = 0;
+                return EOK;
+        }
+
         memcpy(buffer, &data, *actual_size);
         
@@ -152 +184 @@
         .ops = &keyboard_ops,
         .descriptors = &descriptors,
+        .lib_debug_level = 3,
+        .lib_debug_enabled_tags = USBVIRT_DEBUGTAG_ALL,
         .name = "keyboard"
 };
@@ -177 +211 @@
         printf("\n");
         
-        fibril_sleep(1);
+        fibril_sleep(KEY_PRESS_DELAY);
 }
 
@@ -223 +257 @@
         
         printf("%s: Simulating keyboard events...\n", NAME);
-        while(1){
+        while (1) {
                 kb_process_events(&status, keyboard_events, keyboard_events_count,
                         on_keyboard_change);