Changeset 2ee6351 in mainline

Timestamp:

2024-09-12T12:35:23Z (3 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

dd50aa19

Parents:

9c40b834

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-08-20 14:21:37)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-09-12 12:35:23)

Message:

Remove unused/undocumented sx, sy arguments

File:

• uspace/app/terminal/terminal.c (modified) (12 diffs)

uspace/app/terminal/terminal.c

@@ -215 +215 @@
 
 static void term_update_char(terminal_t *term, pixelmap_t *pixelmap,
-    sysarg_t sx, sysarg_t sy, sysarg_t col, sysarg_t row)
+    sysarg_t col, sysarg_t row)
 {
         charfield_t *field =
@@ -222 +222 @@
         bool inverted = chargrid_cursor_at(term->backbuf, col, row);
 
-        sysarg_t bx = sx + (col * FONT_WIDTH);
-        sysarg_t by = sy + (row * FONT_SCANLINES);
+        sysarg_t bx = col * FONT_WIDTH;
+        sysarg_t by = row * FONT_SCANLINES;
 
         pixel_t bgcolor = 0;
@@ -251 +251 @@
 }
 
-static bool term_update_scroll(terminal_t *term, pixelmap_t *pixelmap,
-    sysarg_t sx, sysarg_t sy)
+static bool term_update_scroll(terminal_t *term, pixelmap_t *pixelmap)
 {
         sysarg_t top_row = chargrid_get_top_row(term->frontbuf);
@@ -283 +282 @@
 
                         if (update) {
-                                term_update_char(term, pixelmap, sx, sy, col, row);
+                                term_update_char(term, pixelmap, col, row);
                         }
                 }
@@ -291 +290 @@
 }
 
-static bool term_update_cursor(terminal_t *term, pixelmap_t *pixelmap,
-    sysarg_t sx, sysarg_t sy)
+static bool term_update_cursor(terminal_t *term, pixelmap_t *pixelmap)
 {
         bool update = false;
@@ -313 +311 @@
                 chargrid_set_cursor_visibility(term->backbuf,
                     front_visibility);
-                term_update_char(term, pixelmap, sx, sy, back_col, back_row);
+                term_update_char(term, pixelmap, back_col, back_row);
                 update = true;
         }
@@ -319 +317 @@
         if ((front_col != back_col) || (front_row != back_row)) {
                 chargrid_set_cursor(term->backbuf, front_col, front_row);
-                term_update_char(term, pixelmap, sx, sy, back_col, back_row);
-                term_update_char(term, pixelmap, sx, sy, front_col, front_row);
+                term_update_char(term, pixelmap, back_col, back_row);
+                term_update_char(term, pixelmap, front_col, front_row);
                 update = true;
         }
@@ -345 +343 @@
 
         bool update = false;
-        sysarg_t sx = 0;
-        sysarg_t sy = 0;
-
-        if (term_update_scroll(term, &pixelmap, sx, sy)) {
+
+        if (term_update_scroll(term, &pixelmap)) {
                 update = true;
         } else {
@@ -376 +372 @@
 
                                 if (cupdate) {
-                                        term_update_char(term, &pixelmap, sx, sy, x, y);
+                                        term_update_char(term, &pixelmap, x, y);
                                         update = true;
                                 }
@@ -383 +379 @@
         }
 
-        if (term_update_cursor(term, &pixelmap, sx, sy))
+        if (term_update_cursor(term, &pixelmap))
                 update = true;
 
@@ -418 +414 @@
         pixelmap.data = alloc.pixels;
 
-        sysarg_t sx = 0;
-        sysarg_t sy = 0;
-
-        if (!term_update_scroll(term, &pixelmap, sx, sy)) {
+        if (!term_update_scroll(term, &pixelmap)) {
                 for (sysarg_t y = 0; y < term->rows; y++) {
                         for (sysarg_t x = 0; x < term->cols; x++) {
@@ -433 +426 @@
                                 front_field->flags &= ~CHAR_FLAG_DIRTY;
 
-                                term_update_char(term, &pixelmap, sx, sy, x, y);
+                                term_update_char(term, &pixelmap, x, y);
                         }
                 }
         }
 
-        term_update_cursor(term, &pixelmap, sx, sy);
+        term_update_cursor(term, &pixelmap);
 
         fibril_mutex_unlock(&term->mtx);