Changeset 2f0dd2a in mainline for uspace/srv/net/tl/tcp/conn.c

Timestamp:

2011-12-23T09:56:54Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

153cc76a, 7e1b130

Parents:

fe5e9629

Message:

Stricter RST processing in Syn-sent state.

File:

• uspace/srv/net/tl/tcp/conn.c (modified) (2 diffs)

uspace/srv/net/tl/tcp/conn.c

@@ -491 +491 @@
                     conn->snd_una, seg->ack, conn->snd_nxt);
                 if (!seq_no_ack_acceptable(conn, seg->ack)) {
-                        log_msg(LVL_WARN, "ACK not acceptable, send RST.");
-                        tcp_reply_rst(&conn->ident, seg);
+                        if ((seg->ctrl & CTL_RST) == 0) {
+                                log_msg(LVL_WARN, "ACK not acceptable, send RST");
+                                tcp_reply_rst(&conn->ident, seg);
+                        } else {
+                                log_msg(LVL_WARN, "RST,ACK not acceptable, drop");
+                        }
                         return;
                 }
@@ -498 +502 @@
 
         if ((seg->ctrl & CTL_RST) != 0) {
-                log_msg(LVL_DEBUG, "%s: Connection reset. -> Closed",
-                    conn->name);
-                /* Reset connection */
-                tcp_conn_reset(conn);
-                /* XXX delete connection */
-                return;
+                /* If we get here, we have either an acceptable ACK or no ACK */
+                if ((seg->ctrl & CTL_ACK) != 0) {
+                        log_msg(LVL_DEBUG, "%s: Connection reset. -> Closed",
+                            conn->name);
+                        /* Reset connection */
+                        tcp_conn_reset(conn);
+                        return;
+                } else {
+                        log_msg(LVL_DEBUG, "%s: RST without ACK, drop",
+                            conn->name);
+                        return;
+                }
         }