Changeset 309d9865 in mainline

Timestamp:

2018-01-15T20:44:29Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d2c3dcd

Parents:

957ea3a

Message:

xhci: update dequeue ptr also for cmd ring

Location:

uspace/drv/bus/usb/xhci

Files:

• transfers.c (modified) (1 diff)
• trb_ring.h (modified) (1 diff)

uspace/drv/bus/usb/xhci/transfers.c

@@ -267 +267 @@
         xhci_endpoint_t *ep = xhci_endpoint_get(ep_base);
 
-        /* FIXME: This is racy. Do we care? */
-        ep->ring.dequeue = addr;
+        xhci_trb_ring_update_dequeue(&ep->ring, addr);
 
         if (ep->base.transfer_type == USB_TRANSFER_ISOCHRONOUS) {

uspace/drv/bus/usb/xhci/trb_ring.h

@@ -91 +91 @@
  * pointer inside the ring. Otherwise, the ring will soon show up as full.
  */
-static inline void xhci_trb_ring_update_dequeue(xhci_trb_ring_t *ring, uintptr_t phys) {}
+static inline void xhci_trb_ring_update_dequeue(xhci_trb_ring_t *ring, uintptr_t phys) {
+        ring->dequeue = phys;
+}
+
 uintptr_t xhci_trb_ring_get_dequeue_ptr(xhci_trb_ring_t *);