Changeset 30f1a25 in mainline for kernel/generic/src/ddi/irq.c

Timestamp:

2018-03-14T18:54:08Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

67f11a0

Parents:

963037b0

Message:

Make hash_table_find_next immune to livelocks

By giving hash_table_find_next the item returned from hash_table_find,
we provide it with a fixed reference with which the outer loop which
calls hash_table_find_next can terminate even if the respective bucket
contains more matching elements.

File:

• kernel/generic/src/ddi/irq.c (modified) (1 diff)

kernel/generic/src/ddi/irq.c

@@ -141 +141 @@
 {
         irq_spinlock_lock(l, false);
-        for (ht_link_t *lnk = hash_table_find(h, &inr); lnk;
-            lnk = hash_table_find_next(h, lnk)) {
+        ht_link_t *first = hash_table_find(h, &inr);
+        for (ht_link_t *lnk = first; lnk;
+            lnk = hash_table_find_next(h, first, lnk)) {
                 irq_t *irq = hash_table_get_inst(lnk, irq_t, link);
                 irq_spinlock_lock(&irq->lock, false);