Changes in uspace/app/wavplay/dplay.c [b6e481b:33b8d024] in mainline

File:

• uspace/app/wavplay/dplay.c (modified) (7 diffs)

uspace/app/wavplay/dplay.c

@@ -148 +148 @@
         const size_t fragment_size = pb->buffer.size / DEFAULT_FRAGMENTS;
         printf("Registering event callback\n");
-        int ret = audio_pcm_register_event_callback(pb->device,
+        errno_t ret = audio_pcm_register_event_callback(pb->device,
             device_event_callback, pb);
         if (ret != EOK) {
@@ -282 +282 @@
 
                 if (!started) {
-                        int ret = audio_pcm_start_playback(pb->device,
+                        errno_t ret = audio_pcm_start_playback(pb->device,
                             pb->f.channels, pb->f.sampling_rate,
                             pb->f.sample_format);
@@ -309 +309 @@
                         async_usleep(real_delay);
                 /* update buffer position */
-                const int ret = audio_pcm_get_buffer_pos(pb->device, &pos);
+                const errno_t ret = audio_pcm_get_buffer_pos(pb->device, &pos);
                 if (ret != EOK) {
                         printf("Failed to update position indicator %s\n",
@@ -329 +329 @@
  * @param device The device.
  * @param file The file.
- * @return Error code.
+ * @return 0 on success, non-zero on failure.
  */
 int dplay(const char *device, const char *file)
 {
-        int ret = EOK;
+        errno_t ret = EOK;
         audio_pcm_sess_t *session = NULL;
         if (str_cmp(device, "default") == 0) {
@@ -345 +345 @@
         }
         printf("Playing on device: %s.\n", device);
-        if (audio_pcm_query_cap(session, AUDIO_CAP_PLAYBACK) <= 0) {
+        sysarg_t val;
+        ret = audio_pcm_query_cap(session, AUDIO_CAP_PLAYBACK, &val);
+        if (ret != EOK || !val) {
                 printf("Device %s does not support playback\n", device);
                 ret = ENOTSUP;
@@ -351 +353 @@
         }
 
-        const char* info = NULL;
+        char* info = NULL;
         ret = audio_pcm_get_info_str(session, &info);
         if (ret != EOK) {
@@ -386 +388 @@
                 goto cleanup;
         }
-        if (audio_pcm_query_cap(pb.device, AUDIO_CAP_BUFFER_POS) > 0) {
+        ret = audio_pcm_query_cap(pb.device, AUDIO_CAP_BUFFER_POS, &val);
+        if (ret == EOK && val) {
                 play(&pb);
         } else {
-                if (audio_pcm_query_cap(pb.device, AUDIO_CAP_INTERRUPT) > 0)
+                ret = audio_pcm_query_cap(pb.device, AUDIO_CAP_INTERRUPT, &val);
+                if (ret == EOK && val)
                         play_fragment(&pb);
                 else