Changes in uspace/lib/usb/src/recognise.c [7f56fb7:345ea18] in mainline

File:

• uspace/lib/usb/src/recognise.c (modified) (7 diffs)

uspace/lib/usb/src/recognise.c

@@ -34 +34 @@
  */
 #include <sys/types.h>
+#include <usb_iface.h>
 #include <usb/usbdrv.h>
 #include <usb/pipes.h>
 #include <usb/recognise.h>
-#include <usb/ddfiface.h>
 #include <usb/request.h>
 #include <usb/classes/classes.h>
@@ -46 +46 @@
 static FIBRIL_MUTEX_INITIALIZE(device_name_index_mutex);
 
+/** Callback for getting host controller handle.
+ *
+ * @param dev Device in question.
+ * @param[out] handle Devman handle of the host controller.
+ * @return Error code.
+ */
+static int usb_iface_get_hc_handle(device_t *dev, devman_handle_t *handle)
+{
+        assert(dev);
+        assert(dev->parent != NULL);
+
+        device_t *parent = dev->parent;
+
+        if (parent->ops && parent->ops->interfaces[USB_DEV_IFACE]) {
+                usb_iface_t *usb_iface
+                    = (usb_iface_t *) parent->ops->interfaces[USB_DEV_IFACE];
+                assert(usb_iface != NULL);
+                if (usb_iface->get_hc_handle) {
+                        int rc = usb_iface->get_hc_handle(parent, handle);
+                        return rc;
+                }
+        }
+
+        return ENOTSUP;
+}
+
+static usb_iface_t usb_iface = {
+        .get_hc_handle = usb_iface_get_hc_handle
+};
+
 device_ops_t child_ops = {
-        .interfaces[USB_DEV_IFACE] = &usb_iface_hub_child_impl
+        .interfaces[USB_DEV_IFACE] = &usb_iface
 };
 
@@ -112 +142 @@
 }
 
-#define ADD_MATCHID_OR_RETURN(match_ids, score, format, ...) \
-        do { \
-                int __rc = usb_add_match_id((match_ids), (score), \
-                    format, ##__VA_ARGS__); \
-                if (__rc != EOK) { \
-                        return __rc; \
-                } \
-        } while (0)
-
-/** Create device match ids based on its interface.
- *
- * @param[in] descriptor Interface descriptor.
- * @param[out] matches Initialized list of match ids.
- * @return Error code (the two mentioned are not the only ones).
- * @retval EINVAL Invalid input parameters (expects non NULL pointers).
- * @retval ENOENT Interface does not specify class.
- */
-int usb_device_create_match_ids_from_interface(
-    const usb_standard_device_descriptor_t *desc_device,
-    const usb_standard_interface_descriptor_t *desc_interface,
-    match_id_list_t *matches)
-{
-        if (desc_interface == NULL) {
-                return EINVAL;
-        }
-        if (matches == NULL) {
-                return EINVAL;
-        }
-
-        if (desc_interface->interface_class == USB_CLASS_USE_INTERFACE) {
-                return ENOENT;
-        }
-
-        const char *classname = usb_str_class(desc_interface->interface_class);
-        assert(classname != NULL);
-
-#define IFACE_PROTOCOL_FMT "interface&class=%s&subclass=0x%02x&protocol=0x%02x"
-#define IFACE_PROTOCOL_ARGS classname, desc_interface->interface_subclass, \
-    desc_interface->interface_protocol
-
-#define IFACE_SUBCLASS_FMT "interface&class=%s&subclass=0x%02x"
-#define IFACE_SUBCLASS_ARGS classname, desc_interface->interface_subclass
-
-#define IFACE_CLASS_FMT "interface&class=%s"
-#define IFACE_CLASS_ARGS classname
-
-#define VENDOR_RELEASE_FMT "vendor=0x%04x&product=0x%04x&release=" BCD_FMT
-#define VENDOR_RELEASE_ARGS desc_device->vendor_id, desc_device->product_id, \
-    BCD_ARGS(desc_device->device_version)
-
-#define VENDOR_PRODUCT_FMT "vendor=0x%04x&product=0x%04x"
-#define VENDOR_PRODUCT_ARGS desc_device->vendor_id, desc_device->product_id
-
-#define VENDOR_ONLY_FMT "vendor=0x%04x"
-#define VENDOR_ONLY_ARGS desc_device->vendor_id
-
-        /*
-         * If the vendor is specified, create match ids with vendor with
-         * higher score.
-         * Then the same ones without the vendor part.
-         */
-        if ((desc_device != NULL) && (desc_device->vendor_id != 0)) {
-                /* First, interface matches with device release number. */
-                ADD_MATCHID_OR_RETURN(matches, 250,
-                    "usb&" VENDOR_RELEASE_FMT "&" IFACE_PROTOCOL_FMT,
-                    VENDOR_RELEASE_ARGS, IFACE_PROTOCOL_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 240,
-                    "usb&" VENDOR_RELEASE_FMT "&" IFACE_SUBCLASS_FMT,
-                    VENDOR_RELEASE_ARGS, IFACE_SUBCLASS_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 230,
-                    "usb&" VENDOR_RELEASE_FMT "&" IFACE_CLASS_FMT,
-                    VENDOR_RELEASE_ARGS, IFACE_CLASS_ARGS);
-
-                /* Next, interface matches without release number. */
-                ADD_MATCHID_OR_RETURN(matches, 220,
-                    "usb&" VENDOR_PRODUCT_FMT "&" IFACE_PROTOCOL_FMT,
-                    VENDOR_PRODUCT_ARGS, IFACE_PROTOCOL_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 210,
-                    "usb&" VENDOR_PRODUCT_FMT "&" IFACE_SUBCLASS_FMT,
-                    VENDOR_PRODUCT_ARGS, IFACE_SUBCLASS_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 200,
-                    "usb&" VENDOR_PRODUCT_FMT "&" IFACE_CLASS_FMT,
-                    VENDOR_PRODUCT_ARGS, IFACE_CLASS_ARGS);
-
-                /* Finally, interface matches with only vendor. */
-                ADD_MATCHID_OR_RETURN(matches, 190,
-                    "usb&" VENDOR_ONLY_FMT "&" IFACE_PROTOCOL_FMT,
-                    VENDOR_ONLY_ARGS, IFACE_PROTOCOL_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 180,
-                    "usb&" VENDOR_ONLY_FMT "&" IFACE_SUBCLASS_FMT,
-                    VENDOR_ONLY_ARGS, IFACE_SUBCLASS_ARGS);
-                ADD_MATCHID_OR_RETURN(matches, 170,
-                    "usb&" VENDOR_ONLY_FMT "&" IFACE_CLASS_FMT,
-                    VENDOR_ONLY_ARGS, IFACE_CLASS_ARGS);
-        }
-
-        /* Now, the same but without any vendor specification. */
-        ADD_MATCHID_OR_RETURN(matches, 160,
-            "usb&" IFACE_PROTOCOL_FMT,
-            IFACE_PROTOCOL_ARGS);
-        ADD_MATCHID_OR_RETURN(matches, 150,
-            "usb&" IFACE_SUBCLASS_FMT,
-            IFACE_SUBCLASS_ARGS);
-        ADD_MATCHID_OR_RETURN(matches, 140,
-            "usb&" IFACE_CLASS_FMT,
-            IFACE_CLASS_ARGS);
-
-#undef IFACE_PROTOCOL_FMT
-#undef IFACE_PROTOCOL_ARGS
-#undef IFACE_SUBCLASS_FMT
-#undef IFACE_SUBCLASS_ARGS
-#undef IFACE_CLASS_FMT
-#undef IFACE_CLASS_ARGS
-#undef VENDOR_RELEASE_FMT
-#undef VENDOR_RELEASE_ARGS
-#undef VENDOR_PRODUCT_FMT
-#undef VENDOR_PRODUCT_ARGS
-#undef VENDOR_ONLY_FMT
-#undef VENDOR_ONLY_ARGS
-
-        return EOK;
-}
-
 /** Create DDF match ids from USB device descriptor.
  *
@@ -245 +152 @@
     const usb_standard_device_descriptor_t *device_descriptor)
 {
+        int rc;
+        
         /*
          * Unless the vendor id is 0, the pair idVendor-idProduct
@@ -251 +160 @@
         if (device_descriptor->vendor_id != 0) {
                 /* First, with release number. */
-                ADD_MATCHID_OR_RETURN(matches, 100,
+                rc = usb_add_match_id(matches, 100,
                     "usb&vendor=0x%04x&product=0x%04x&release=" BCD_FMT,
                     (int) device_descriptor->vendor_id,
                     (int) device_descriptor->product_id,
                     BCD_ARGS(device_descriptor->device_version));
+                if (rc != EOK) {
+                        return rc;
+                }
                 
                 /* Next, without release number. */
-                ADD_MATCHID_OR_RETURN(matches, 90,
+                rc = usb_add_match_id(matches, 90,
                     "usb&vendor=0x%04x&product=0x%04x",
                     (int) device_descriptor->vendor_id,
                     (int) device_descriptor->product_id);
+                if (rc != EOK) {
+                        return rc;
+                }
         }       
 
         /*
          * If the device class points to interface we skip adding
-         * class directly but we add a multi interface device.
+         * class directly.
          */
         if (device_descriptor->device_class != USB_CLASS_USE_INTERFACE) {
-                ADD_MATCHID_OR_RETURN(matches, 50, "usb&class=%s",
+                rc = usb_add_match_id(matches, 50, "usb&class=%s",
                     usb_str_class(device_descriptor->device_class));
-        } else {
-                ADD_MATCHID_OR_RETURN(matches, 50, "usb&mid");
+                if (rc != EOK) {
+                        return rc;
+                }
         }
         
@@ -278 +194 @@
 }
 
+/** Create DDF match ids from USB configuration descriptor.
+ * The configuration descriptor is expected to be in the complete form,
+ * i.e. including interface, endpoint etc. descriptors.
+ *
+ * @param matches List of match ids to extend.
+ * @param config_descriptor Configuration descriptor returned by given device.
+ * @param total_size Size of the @p config_descriptor.
+ * @return Error code.
+ */
+int usb_drv_create_match_ids_from_configuration_descriptor(
+    match_id_list_t *matches,
+    const void *config_descriptor, size_t total_size)
+{
+        /*
+         * Iterate through config descriptor to find the interface
+         * descriptors.
+         */
+        size_t position = sizeof(usb_standard_configuration_descriptor_t);
+        while (position + 1 < total_size) {
+                uint8_t *current_descriptor
+                    = ((uint8_t *) config_descriptor) + position;
+                uint8_t cur_descr_len = current_descriptor[0];
+                uint8_t cur_descr_type = current_descriptor[1];
+
+                if (cur_descr_len == 0) {
+                        return ENOENT;
+                }
+                
+                position += cur_descr_len;
+                
+                if (cur_descr_type != USB_DESCTYPE_INTERFACE) {
+                        continue;
+                }
+                
+                /*
+                 * Finally, we found an interface descriptor.
+                 */
+                usb_standard_interface_descriptor_t *interface
+                    = (usb_standard_interface_descriptor_t *)
+                    current_descriptor;
+                
+                int rc = usb_add_match_id(matches, 50,
+                    "usb&interface&class=%s",
+                    usb_str_class(interface->interface_class));
+                if (rc != EOK) {
+                        return rc;
+                }
+        }
+        
+        return EOK;
+}
+
+/** Add match ids based on configuration descriptor.
+ *
+ * @param pipe Control pipe to the device.
+ * @param matches Match ids list to add matches to.
+ * @param config_count Number of configurations the device has.
+ * @return Error code.
+ */
+static int usb_add_config_descriptor_match_ids(usb_endpoint_pipe_t *pipe,
+    match_id_list_t *matches, int config_count)
+{
+        int final_rc = EOK;
+        
+        int config_index;
+        for (config_index = 0; config_index < config_count; config_index++) {
+                int rc;
+                usb_standard_configuration_descriptor_t config_descriptor;
+                rc = usb_request_get_bare_configuration_descriptor(pipe,
+                    config_index, &config_descriptor);
+                if (rc != EOK) {
+                        final_rc = rc;
+                        continue;
+                }
+
+                size_t full_config_descriptor_size;
+                void *full_config_descriptor
+                    = malloc(config_descriptor.total_length);
+                rc = usb_request_get_full_configuration_descriptor(pipe,
+                    config_index,
+                    full_config_descriptor, config_descriptor.total_length,
+                    &full_config_descriptor_size);
+                if (rc != EOK) {
+                        final_rc = rc;
+                        continue;
+                }
+                if (full_config_descriptor_size
+                    != config_descriptor.total_length) {
+                        final_rc = ERANGE;
+                        continue;
+                }
+                
+                rc = usb_drv_create_match_ids_from_configuration_descriptor(
+                    matches,
+                    full_config_descriptor, full_config_descriptor_size);
+                if (rc != EOK) {
+                        final_rc = rc;
+                        continue;
+                }
+                
+        }
+        
+        return final_rc;
+}
 
 /** Create match ids describing attached device.
@@ -310 +330 @@
 
         /*
+         * Go through all configurations and add matches
+         * based on interface class.
+         */
+        rc = usb_add_config_descriptor_match_ids(ctrl_pipe, matches,
+            device_descriptor.configuration_count);
+        if (rc != EOK) {
+                return rc;
+        }
+
+        /*
          * As a fallback, provide the simplest match id possible.
          */
-        ADD_MATCHID_OR_RETURN(matches, 1, "usb&fallback");
+        rc = usb_add_match_id(matches, 1, "usb&fallback");
+        if (rc != EOK) {
+                return rc;
+        }
 
         return EOK;