Changes in / [c8bb1633:3908355] in mainline

Location:

uspace/srv/fs/mfs

Files:

• mfs_balloc.c (modified) (3 diffs)
• mfs_dentry.c (modified) (3 diffs)
• mfs_ops.c (modified) (15 diffs)

uspace/srv/fs/mfs/mfs_balloc.c

@@ -128 +128 @@
                 start_block = 2 + sbi->ibmap_blocks;
                 if (idx > sbi->nzones) {
-                        printf(NAME ": Error! Trying to free beyond the" \
+                        printf(NAME ": Error! Trying to free beyond the "
                             "bitmap max size\n");
                         return -1;
@@ -137 +137 @@
                 start_block = 2;
                 if (idx > sbi->ninodes) {
-                        printf(NAME ": Error! Trying to free beyond the" \
+                        printf(NAME ": Error! Trying to free beyond the "
                             "bitmap max size\n");
                         return -1;
@@ -202 +202 @@
                 start_block = 2;
                 nblocks = sbi->ibmap_blocks;
-                limit = sbi->ninodes;
+                limit = sbi->ninodes - 1;
         }
         bits_per_block = sbi->block_size * 8;

uspace/srv/fs/mfs/mfs_dentry.c

@@ -36 +36 @@
  *
  * @param mnode         Pointer to the directory node.
- * @param d_info        Pointer to a directory entry structure where the dentry info
- *                      will be stored.
+ * @param d_info        Pointer to a directory entry structure where
+ *                      the dentry info will be stored.
  * @param index         index of the dentry in the list.
  *
@@ -101 +101 @@
 /**Write a directory entry on disk.
  *
- * @param d_info Pointer to the directory entry structure to write on disk.
+ * @param d_info The directory entry to write to disk.
  *
  * @return       EOK on success or a negative error code.
@@ -240 +240 @@
                                 goto out;
                         r = mfs_write_map(mnode, pos, b, &dummy);
-                        if (r != EOK)
+                        if (r != EOK) {
+                                mfs_free_zone(mnode->instance, b);
                                 goto out;
+                        }
                 }
 

uspace/srv/fs/mfs/mfs_ops.c

@@ -88 +88 @@
 
 /* Hash table interface for open nodes hash table */
-
 typedef struct {
         service_id_t service_id;
@@ -190 +189 @@
                 /* This is a V1 or V2 Minix filesystem */
                 magic = sb->s_magic;
-        } else if (check_magic_number(sb3->s_magic, &native, &version, &longnames)) {
+        } else if (check_magic_number(sb3->s_magic, &native,
+            &version, &longnames)) {
                 /* This is a V3 Minix filesystem */
                 magic = sb3->s_magic;
@@ -345 +345 @@
         uint32_t inum;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         r = mfs_instance_get(service_id, &inst);
         if (r != EOK)
@@ -379 +377 @@
                 ino_i->i_mode = S_IFDIR;
                 ino_i->i_nlinks = 1; /* This accounts for the '.' dentry */
-        } else
+        } else {
                 ino_i->i_mode = S_IFREG;
+                ino_i->i_nlinks = 0;
+        }
 
         ino_i->i_uid = 0;
@@ -419 +419 @@
         free(ino_i);
 out_err:
+        mfs_free_inode(inst, inum);
         return r;
 }
@@ -429 +430 @@
         struct mfs_dentry_info d_info;
         int r;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         if (!S_ISDIR(ino_i->i_mode))
@@ -478 +477 @@
         struct mfs_instance *instance;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         rc = mfs_instance_get(service_id, &instance);
         if (rc != EOK)
@@ -492 +489 @@
         int rc = EOK;
         struct mfs_node *mnode = fsnode->data;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         fibril_mutex_lock(&open_nodes_lock);
@@ -554 +549 @@
         int rc;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         fibril_mutex_lock(&open_nodes_lock);
 
@@ -568 +561 @@
         if (already_open) {
                 mnode = hash_table_get_inst(already_open, struct mfs_node, link);
+
                 *rfn = mnode->fsnode;
                 mnode->refcnt++;
@@ -649 +643 @@
         bool destroy_dentry = false;
 
-        mfsdebug("%s()\n", __FUNCTION__);
-
         if (str_size(name) > sbi->max_name_len)
                 return ENAMETOOLONG;
@@ -673 +665 @@
                 r = mfs_insert_dentry(child, "..", parent->ino_i->index);
                 if (r != EOK) {
+                        mfs_remove_dentry(child, ".");
                         destroy_dentry = true;
                         goto exit;
@@ -700 +693 @@
         bool has_children;
         int r;
-
-        mfsdebug("%s()\n", __FUNCTION__);
 
         if (!parent)
@@ -924 +915 @@
                 
                 r = mfs_write_map(mnode, pos, block, &dummy);
-                if (r != EOK)
+                if (r != EOK) {
+                        mfs_free_zone(mnode->instance, block);
                         goto out_err;
+                }
 
                 flags = BLOCK_FLAGS_NOREAD;
@@ -965 +958 @@
 mfs_destroy(service_id_t service_id, fs_index_t index)
 {
-        fs_node_t *fn;
+        fs_node_t *fn = NULL;
         int r;