Changes in uspace/lib/usb/src/devdrv.c [e484f3b:3954a63b] in mainline

File:

• uspace/lib/usb/src/devdrv.c (modified) (5 diffs)

uspace/lib/usb/src/devdrv.c

@@ -137 +137 @@
         }
 
-        rc = usb_pipe_initialize_from_configuration(dev->pipes, pipe_count,
-            dev->descriptors.configuration, dev->descriptors.configuration_size,
-            &dev->wire);
+        void *config_descriptor;
+        size_t config_descriptor_size;
+        rc = usb_request_get_full_configuration_descriptor_alloc(
+            &dev->ctrl_pipe, 0, &config_descriptor, &config_descriptor_size);
+        if (rc != EOK) {
+                usb_log_error("Failed retrieving configuration of `%s': %s.\n",
+                    dev->ddf_dev->name, str_error(rc));
+                goto rollback;
+        }
+
+        rc = usb_pipe_initialize_from_configuration(dev->pipes,
+           pipe_count, config_descriptor, config_descriptor_size, &dev->wire);
         if (rc != EOK) {
                 usb_log_error("Failed initializing USB endpoints: %s.\n",
@@ -228 +237 @@
 
         /*
-         * For further actions, we need open session on default control pipe.
+         * Initialization of other pipes requires open session on
+         * default control pipe.
          */
         rc = usb_pipe_start_session(&dev->ctrl_pipe);
@@ -237 +247 @@
         }
 
-        /* Get the device descriptor. */
-        rc = usb_request_get_device_descriptor(&dev->ctrl_pipe,
-            &dev->descriptors.device);
-        if (rc != EOK) {
-                usb_log_error("Failed to retrieve device descriptor: %s.\n",
-                    str_error(rc));
-                return rc;
-        }
-
-        /* Get the full configuration descriptor. */
-        rc = usb_request_get_full_configuration_descriptor_alloc(
-            &dev->ctrl_pipe, 0, (void **) &dev->descriptors.configuration,
-            &dev->descriptors.configuration_size);
-        if (rc != EOK) {
-                usb_log_error("Failed retrieving configuration descriptor: %s.\n",
-                    dev->ddf_dev->name, str_error(rc));
-                return rc;
-        }
-
         if (driver->endpoints != NULL) {
                 rc = initialize_other_pipes(driver, dev);
@@ -262 +253 @@
         /* No checking here. */
         usb_pipe_end_session(&dev->ctrl_pipe);
-
-        /* Rollback actions. */
-        if (rc != EOK) {
-                if (dev->descriptors.configuration != NULL) {
-                        free(dev->descriptors.configuration);
-                }
-        }
 
         return rc;
@@ -299 +283 @@
         dev->ddf_dev->driver_data = dev;
         dev->driver_data = NULL;
-        dev->descriptors.configuration = NULL;
 
         rc = initialize_pipes(dev);