Changes in uspace/srv/devman/main.c [79ae36dd:3ad7b1c] in mainline

File:

• uspace/srv/devman/main.c (modified) (12 diffs)

uspace/srv/devman/main.c

@@ -39 +39 @@
 #include <assert.h>
 #include <ipc/services.h>
-#include <ns.h>
+#include <ipc/ns.h>
 #include <async.h>
 #include <stdio.h>
@@ -108 +108 @@
         fibril_mutex_lock(&driver->driver_mutex);
         
-        if (driver->sess) {
+        if (driver->phone >= 0) {
                 /* We already have a connection to the driver. */
                 log_msg(LVL_ERROR, "Driver '%s' already started.\n",
@@ -128 +128 @@
                 break;
         case DRIVER_RUNNING:
-                /* Should not happen since we do not have a connected session */
+                /* Should not happen since we do not have a connected phone */
                 assert(false);
         }
@@ -135 +135 @@
         log_msg(LVL_DEBUG, "Creating connection to the `%s' driver.",
             driver->name);
-        driver->sess = async_callback_receive(EXCHANGE_SERIALIZE);
-        if (!driver->sess) {
+        ipc_call_t call;
+        ipc_callid_t callid = async_get_call(&call);
+        if (IPC_GET_IMETHOD(call) != IPC_M_CONNECT_TO_ME) {
                 fibril_mutex_unlock(&driver->driver_mutex);
+                async_answer_0(callid, ENOTSUP);
                 async_answer_0(iid, ENOTSUP);
                 return NULL;
         }
         
+        /* Remember driver's phone. */
+        driver->phone = IPC_GET_ARG5(call);
+        
         fibril_mutex_unlock(&driver->driver_mutex);
         
-        log_msg(LVL_NOTE,
+        log_msg(LVL_NOTE, 
             "The `%s' driver was successfully registered as running.",
             driver->name);
         
+        async_answer_0(callid, EOK);
         async_answer_0(iid, EOK);
         
@@ -428 +434 @@
         fibril_add_ready(fid);
         
-        while (true) {
-                ipc_call_t call;
-                ipc_callid_t callid = async_get_call(&call);
-                
-                if (!IPC_GET_IMETHOD(call))
-                        break;
+        ipc_callid_t callid;
+        ipc_call_t call;
+        bool cont = true;
+        while (cont) {
+                callid = async_get_call(&call);
                 
                 switch (IPC_GET_IMETHOD(call)) {
+                case IPC_M_PHONE_HUNGUP:
+                        cont = false;
+                        continue;
                 case DEVMAN_ADD_FUNCTION:
                         devman_add_function(callid, &call);
@@ -507 +515 @@
 }
 
-/** Find device path by its handle. */
-static void devman_get_device_path_by_handle(ipc_callid_t iid,
-    ipc_call_t *icall)
-{
-        devman_handle_t handle = IPC_GET_ARG1(*icall);
-
-        fun_node_t *fun = find_fun_node(&device_tree, handle);
-        if (fun == NULL) {
-                async_answer_0(iid, ENOMEM);
-                return;
-        }
-
-        ipc_callid_t data_callid;
-        size_t data_len;
-        if (!async_data_read_receive(&data_callid, &data_len)) {
-                async_answer_0(iid, EINVAL);
-                return;
-        }
-
-        void *buffer = malloc(data_len);
-        if (buffer == NULL) {
-                async_answer_0(data_callid, ENOMEM);
-                async_answer_0(iid, ENOMEM);
-                return;
-        }
-
-        size_t sent_length = str_size(fun->pathname);
-        if (sent_length > data_len) {
-                sent_length = data_len;
-        }
-
-        async_data_read_finalize(data_callid, fun->pathname, sent_length);
-        async_answer_0(iid, EOK);
-
-        free(buffer);
-}
-
 
 /** Function for handling connections from a client to the device manager. */
@@ -551 +522 @@
         async_answer_0(iid, EOK);
         
-        while (true) {
+        bool cont = true;
+        while (cont) {
                 ipc_call_t call;
                 ipc_callid_t callid = async_get_call(&call);
                 
-                if (!IPC_GET_IMETHOD(call))
-                        break;
-                
                 switch (IPC_GET_IMETHOD(call)) {
+                case IPC_M_PHONE_HUNGUP:
+                        cont = false;
+                        continue;
                 case DEVMAN_DEVICE_GET_HANDLE:
                         devman_function_get_handle(callid, &call);
@@ -564 +536 @@
                 case DEVMAN_DEVICE_GET_HANDLE_BY_CLASS:
                         devman_function_get_handle_by_class(callid, &call);
-                        break;
-                case DEVMAN_DEVICE_GET_DEVICE_PATH:
-                        devman_get_device_path_by_handle(callid, &call);
                         break;
                 default:
@@ -637 +606 @@
                 method = DRIVER_CLIENT;
         
-        if (!driver->sess) {
-                log_msg(LVL_ERROR,
-                    "Could not forward to driver `%s'.", driver->name);
+        if (driver->phone < 0) {
+                log_msg(LVL_ERROR, 
+                    "Could not forward to driver `%s' (phone is %d).",
+                    driver->name, (int) driver->phone);
                 async_answer_0(iid, EINVAL);
                 return;
@@ -653 +623 @@
                     dev->pfun->pathname, driver->name);
         }
-        
-        async_exch_t *exch = async_exchange_begin(driver->sess);
-        async_forward_fast(iid, exch, method, fwd_h, 0, IPC_FF_NONE);
-        async_exchange_end(exch);
+
+        async_forward_fast(iid, driver->phone, method, fwd_h, 0, IPC_FF_NONE);
 }
 
@@ -678 +646 @@
         dev = fun->dev;
         
-        if ((dev->state != DEVICE_USABLE) || (!dev->drv->sess)) {
+        if (dev->state != DEVICE_USABLE || dev->drv->phone < 0) {
                 async_answer_0(iid, EINVAL);
                 return;
         }
         
-        async_exch_t *exch = async_exchange_begin(dev->drv->sess);
-        async_forward_fast(iid, exch, DRIVER_CLIENT, fun->handle, 0,
+        async_forward_fast(iid, dev->drv->phone, DRIVER_CLIENT, fun->handle, 0,
             IPC_FF_NONE);
-        async_exchange_end(exch);
-        
-        log_msg(LVL_DEBUG,
+        log_msg(LVL_DEBUG, 
             "Forwarding devmapper request for `%s' function to driver `%s'.",
             fun->pathname, dev->drv->name);
@@ -780 +745 @@
 
         printf(NAME ": Accepting connections.\n");
-        task_retval(0);
         async_manager();