Changeset 3b68542 in mainline

Timestamp:

2024-01-14T17:44:54Z (12 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

4760793

Parents:

6677acb

Message:

Eliminate an undefined behavior in scheduler debug printout

The .relink_deadline field is only normally accessed by the local CPU
and is not synchronized in any way. This is technically undefined
behavior, even if the only realistic failure mode I can think of here
is the output value being nonsense. Because the printed out value has
next to no utility to anyone using the command, simply remove it
instead of ignoring the issue or making the variable atomic.

File:

• kernel/generic/src/proc/scheduler.c (modified) (1 diff)

kernel/generic/src/proc/scheduler.c

@@ -686 +686 @@
                         continue;
 
-                /* Technically a data race, but we don't really care in this case. */
-                int needs_relink = cpus[cpu].relink_deadline - cpus[cpu].current_clock_tick;
-
-                printf("cpu%u: address=%p, nrdy=%zu, needs_relink=%d\n",
-                    cpus[cpu].id, &cpus[cpu], atomic_load(&cpus[cpu].nrdy),
-                    needs_relink);
+                printf("cpu%u: address=%p, nrdy=%zu\n",
+                    cpus[cpu].id, &cpus[cpu], atomic_load(&cpus[cpu].nrdy));
 
                 unsigned int i;