Changes in / [8971926:3dfdcb7] in mainline

Location:

uspace/drv

Files:

• ohci/root_hub.c (modified) (4 diffs)
• usbhub/main.c (modified) (1 diff)
• usbhub/usbhub.c (modified) (1 diff)

uspace/drv/ohci/root_hub.c

@@ -57 +57 @@
         .device_version = 0,
         .length = sizeof (usb_standard_device_descriptor_t),
+        /// \TODO this value is guessed
         .max_packet_size = 8,
         .vendor_id = 0x16db,
@@ -467 +468 @@
 
         usb_hub_bm_request_type_t request_type = request_packet->request_type;
-        if (buffer_size < 4) {
+        if (buffer_size < 4/*request_packet->length*/) {///\TODO
                 usb_log_warning("requested more data than buffer size\n");
                 return EINVAL;
@@ -677 +678 @@
             (instance->registers->rh_port_status[port - 1] | (1 << feature))
             & (~port_clear_feature_valid_mask);
+        /// \TODO any error?
+
         return EOK;
 }
@@ -704 +707 @@
             & (~port_clear_feature_valid_mask))
             | (1 << feature);
+        /// \TODO any error?
 
         return EOK;

uspace/drv/usbhub/main.c

@@ -87 +87 @@
 
         usb_log_enable(USB_LOG_LEVEL_DEFAULT, NAME);
-
+        
         return usb_driver_main(&usb_hub_driver);
 }

uspace/drv/usbhub/usbhub.c

@@ -249 +249 @@
         usb_log_debug("setting port count to %d\n", descriptor->ports_count);
         hub_info->port_count = descriptor->ports_count;
+        /// \TODO this is not semantically correct
         bool is_power_switched =
             ((descriptor->hub_characteristics & 1) == 0);