Changes in / [4776ba9:3f2af64] in mainline

Location:

uspace

Files:

• app/netstart/self_test.c (deleted)
• app/netstart/self_test.h (deleted)
• drv/ohci/iface.c (modified) (4 diffs)
• drv/uhci-hcd/iface.c (modified) (4 diffs)
• lib/packet/include/net_byteorder.h (added)
• lib/packet/include/net_err.h (added)
• lib/packet/include/socket_errno.h (added)
• lib/usb/src/host/endpoint.c (modified) (1 diff)

uspace/drv/ohci/iface.c

@@ -63 +63 @@
         }
 
-        usb_log_debug("%s %d:%d %zu(%zu).\n",
-            name, target.address, target.endpoint, size, ep->max_packet_size);
-
         const size_t bw = bandwidth_count_usb11(
             ep->speed, ep->transfer_type, size, ep->max_packet_size);
@@ -71 +68 @@
                 usb_log_error("Endpoint(%d:%d) %s needs %zu bw "
                     "but only %zu is reserved.\n",
-                    target.address, target.endpoint, name, bw, res_bw);
+                    name, target.address, target.endpoint, bw, res_bw);
                 return ENOSPC;
         }
+        usb_log_debug("%s %d:%d %zu(%zu).\n",
+            name, target.address, target.endpoint, size, ep->max_packet_size);
 
         *batch = batch_get(
@@ -158 +157 @@
         hc_t *hc = fun_to_hc(fun);
         assert(hc);
-
+        if (address == hc->rh.address)
+                return EOK;
         usb_speed_t speed = usb_device_keeper_get_speed(&hc->manager, address);
         if (speed >= USB_SPEED_MAX) {
                 speed = ep_speed;
         }
-        const size_t size = max_packet_size;
+        const size_t size =
+            (transfer_type == USB_TRANSFER_INTERRUPT
+            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
+            max_packet_size : 0;
         int ret;
-
-        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
-            address, endpoint, usb_str_transfer_type(transfer_type),
-            usb_str_speed(speed), direction, size, max_packet_size, interval);
 
         endpoint_t *ep = malloc(sizeof(endpoint_t));
@@ -179 +178 @@
                 return ret;
         }
+
+        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
+            address, endpoint, usb_str_transfer_type(transfer_type),
+            usb_str_speed(speed), direction, size, max_packet_size, interval);
 
         ret = usb_endpoint_manager_register_ep(&hc->ep_manager, ep, size);

uspace/drv/uhci-hcd/iface.c

@@ -63 +63 @@
         }
 
-        usb_log_debug("%s %d:%d %zu(%zu).\n",
-            name, target.address, target.endpoint, size, ep->max_packet_size);
-
         const size_t bw = bandwidth_count_usb11(
             ep->speed, ep->transfer_type, size, ep->max_packet_size);
@@ -71 +68 @@
                 usb_log_error("Endpoint(%d:%d) %s needs %zu bw "
                     "but only %zu is reserved.\n",
-                    target.address, target.endpoint, name, bw, res_bw);
+                    name, target.address, target.endpoint, bw, res_bw);
                 return ENOSPC;
         }
+        usb_log_debug("%s %d:%d %zu(%zu).\n",
+            name, target.address, target.endpoint, size, ep->max_packet_size);
 
         *batch = batch_get(
@@ -147 +146 @@
         hc_t *hc = fun_to_hc(fun);
         assert(hc);
-        const size_t size = max_packet_size;
-        int ret;
         usb_speed_t speed = usb_device_keeper_get_speed(&hc->manager, address);
         if (speed >= USB_SPEED_MAX) {
                 speed = ep_speed;
         }
-        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
-            address, endpoint, usb_str_transfer_type(transfer_type),
-            usb_str_speed(speed), direction, size, max_packet_size, interval);
-
+        const size_t size =
+            (transfer_type == USB_TRANSFER_INTERRUPT
+            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
+            max_packet_size : 0;
+        int ret;
 
         endpoint_t *ep = malloc(sizeof(endpoint_t));
@@ -168 +166 @@
         }
 
+        usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
+            address, endpoint, usb_str_transfer_type(transfer_type),
+            usb_str_speed(speed), direction, size, max_packet_size, interval);
+
         ret = usb_endpoint_manager_register_ep(&hc->ep_manager, ep, size);
         if (ret != EOK) {

uspace/lib/usb/src/host/endpoint.c

@@ -99 +99 @@
         assert(instance);
         if (instance->address == target.address &&
-            (instance->endpoint == target.endpoint || target.endpoint == 0))
+            instance->endpoint == target.endpoint)
                 instance->toggle = 0;
 }