Changeset 3fcea34 in mainline for kernel/arch/arm64/src/arm64.c

Timestamp:

2024-09-20T12:16:28Z (5 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

d3109ff

Parents:

2cf8f994

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-09-20 11:42:13)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-09-20 12:16:28)

Message:

Simplify the SYS_THREAD_CREATE syscall interface

Removed the beefy uarg structure. Instead, the syscall gets two
parameters: %pc (program counter) and %sp (stack pointer). It starts
a thread with those values in corresponding registers, with no other
fuss whatsoever.

libc initializes threads by storing any other needed arguments on
the stack and retrieving them in thread_entry. Importantly, this
includes the address of the thread_main function which is now
called indirectly to fix dynamic linking issues on some archs.

There's a bit of weirdness on SPARC and IA-64, because of their
stacked register handling. The current solution is that we require
some space *above* the stack pointer to be available for those
architectures. I think for SPARC, it can be made more normal.

For the remaining ones, we can (probably) just set the initial
%sp to the top edge of the stack. There's some lingering offsets
on some archs just because I didn't want to accidentally break
anything. The initial thread bringup should be functionally
unchanged from the previous state, and no binaries are currently
multithreaded except thread1 test, so there should be minimal
risk of breakage. Naturally, I tested all available emulator
builds, save for msim.

File:

• kernel/arch/arm64/src/arm64.c (modified) (4 diffs)

kernel/arch/arm64/src/arm64.c

@@ -146 +146 @@
 }
 
+uintptr_t arch_get_initial_sp(uintptr_t stack_base, uintptr_t stack_size)
+{
+        return stack_base + stack_size;
+}
+
 /** Change processor mode.
  *
  * @param kernel_uarg Userspace settings (entry point, stack, ...).
  */
-void userspace(uspace_arg_t *kernel_uarg)
+void userspace(uintptr_t pc, uintptr_t sp)
 {
         /* Prepare return to EL0. */
@@ -157 +162 @@
 
         /* Set program entry. */
-        ELR_EL1_write(kernel_uarg->uspace_entry);
+        ELR_EL1_write(pc);
 
         /* Set user stack. */
-        SP_EL0_write(kernel_uarg->uspace_stack +
-            kernel_uarg->uspace_stack_size);
+        SP_EL0_write(sp);
 
         /* Clear Thread ID register. */
@@ -170 +174 @@
              * Reset the kernel stack to its base value.
              *
-             * Clear all general-purpose registers,
-             * except x0 that holds an argument for
-             * the user space.
+             * Clear all general-purpose registers.
              */
             "mov sp, %[kstack]\n"
-            "mov x0, %[uspace_uarg]\n"
+            "mov x0, #0\n"
             "mov x1, #0\n"
             "mov x2, #0\n"
@@ -207 +209 @@
             "mov x30, #0\n"
             "eret\n"
-            :: [uspace_uarg] "r" (kernel_uarg->uspace_uarg),
-              [kstack] "r" (((uint64_t) (THREAD->kstack)) +
+            :: [kstack] "r" (((uint64_t) (THREAD->kstack)) +
               MEM_STACK_SIZE - SP_DELTA)
         );