Changeset 40ffda8 in mainline for uspace/srv

Timestamp:

2011-05-28T12:15:34Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7bf12387

Parents:

55f81a39

git-author:

Jeff Rous <jeffrous@…> (2011-05-28 12:15:34)

git-committer:

Jakub Jermar <jakub@…> (2011-05-28 12:15:34)

Message:

ip: Remove bit fields and use defines and bitwise ops instead.

File:

• uspace/srv/net/il/ip/ip.c (modified) (14 diffs)

uspace/srv/net/il/ip/ip.c

@@ -201 +201 @@
 
         /* Set the destination address */
-        switch (header->version) {
+        switch (GET_HEADER_VERSION(header)) {
         case IPVERSION:
                 addrlen = sizeof(dest_in);
@@ -635 +635 @@
 
         /* Process all IP options */
-        while (next < first->header_length) {
+        while (next < GET_HEADER_LENGTH(first)) {
                 option = (ip_option_t *) (((uint8_t *) first) + next);
                 /* Skip end or noop */
@@ -656 +656 @@
         if (length % 4) {
                 bzero(((uint8_t *) last) + length, 4 - (length % 4));
-                last->header_length = length / 4 + 1;
+                SET_HEADER_LENGTH(last, (length / 4 + 1));
         } else {
-                last->header_length = length / 4;
+                SET_HEADER_LENGTH(last, (length / 4));
         }
 
@@ -706 +706 @@
                 return rc;
         
-        header->version = IPV4;
-        header->fragment_offset_high = 0;
+        SET_HEADER_VERSION(header, IPV4);
+        SET_HEADER_FRAGMENT_OFFSET_HIGH(header, 0);
         header->fragment_offset_low = 0;
         header->header_checksum = 0;
@@ -735 +735 @@
                         memcpy(middle_header, last_header,
                             IP_HEADER_LENGTH(last_header));
-                        header->flags |= IPFLAG_MORE_FRAGMENTS;
+                        SET_HEADER_FLAGS(header,
+                            (GET_HEADER_FLAGS(header) | IPFLAG_MORE_FRAGMENTS));
                         middle_header->total_length =
                             htons(packet_get_data_length(next));
-                        middle_header->fragment_offset_high =
-                            IP_COMPUTE_FRAGMENT_OFFSET_HIGH(length);
+                        SET_HEADER_FRAGMENT_OFFSET_HIGH(middle_header,
+                            IP_COMPUTE_FRAGMENT_OFFSET_HIGH(length));
                         middle_header->fragment_offset_low =
                             IP_COMPUTE_FRAGMENT_OFFSET_LOW(length);
@@ -768 +769 @@
                 middle_header->total_length =
                     htons(packet_get_data_length(next));
-                middle_header->fragment_offset_high =
-                    IP_COMPUTE_FRAGMENT_OFFSET_HIGH(length);
+                SET_HEADER_FRAGMENT_OFFSET_HIGH(middle_header,
+                    IP_COMPUTE_FRAGMENT_OFFSET_HIGH(length));
                 middle_header->fragment_offset_low =
                     IP_COMPUTE_FRAGMENT_OFFSET_LOW(length);
@@ -785 +786 @@
                 length += packet_get_data_length(next);
                 free(last_header);
-                header->flags |= IPFLAG_MORE_FRAGMENTS;
+                SET_HEADER_FLAGS(header,
+                    (GET_HEADER_FLAGS(header) | IPFLAG_MORE_FRAGMENTS));
         }
 
@@ -834 +836 @@
         new_header->total_length = htons(IP_HEADER_LENGTH(new_header) + length);
         offset = IP_FRAGMENT_OFFSET(header) + IP_HEADER_DATA_LENGTH(header);
-        new_header->fragment_offset_high =
-            IP_COMPUTE_FRAGMENT_OFFSET_HIGH(offset);
+        SET_HEADER_FRAGMENT_OFFSET_HIGH(new_header,
+            IP_COMPUTE_FRAGMENT_OFFSET_HIGH(offset));
         new_header->fragment_offset_low =
             IP_COMPUTE_FRAGMENT_OFFSET_LOW(offset);
@@ -865 +867 @@
                 return NULL;
         memcpy(middle, last, IP_HEADER_LENGTH(last));
-        middle->flags |= IPFLAG_MORE_FRAGMENTS;
+        SET_HEADER_FLAGS(middle,
+            (GET_HEADER_FLAGS(middle) | IPFLAG_MORE_FRAGMENTS));
         return middle;
 }
@@ -922 +925 @@
 
         /* Fragmentation forbidden? */
-        if(header->flags & IPFLAG_DONT_FRAGMENT)
+        if(GET_HEADER_FLAGS(header) & IPFLAG_DONT_FRAGMENT)
                 return EPERM;
 
@@ -958 +961 @@
 
         /* Mark the first as fragmented */
-        header->flags |= IPFLAG_MORE_FRAGMENTS;
+        SET_HEADER_FLAGS(header,
+            (GET_HEADER_FLAGS(header) | IPFLAG_MORE_FRAGMENTS));
 
         /* Create middle fragments */
@@ -1319 +1323 @@
         int rc;
 
-        if ((header->flags & IPFLAG_MORE_FRAGMENTS) ||
+        if ((GET_HEADER_FLAGS(header) & IPFLAG_MORE_FRAGMENTS) ||
             IP_FRAGMENT_OFFSET(header)) {
                 // TODO fragmented
@@ -1325 +1329 @@
         }
         
-        switch (header->version) {
+        switch (GET_HEADER_VERSION(header)) {
         case IPVERSION:
                 addrlen = sizeof(src_in);
@@ -1447 +1451 @@
 
         /* Set the destination address */
-        switch (header->version) {
+        switch (GET_HEADER_VERSION(header)) {
         case IPVERSION:
                 addrlen = sizeof(addr_in);