Changes in uspace/drv/ehci-hcd/pci.c [8855939:4125b7d] in mainline

File:

• uspace/drv/ehci-hcd/pci.c (modified) (5 diffs)

uspace/drv/ehci-hcd/pci.c

@@ -54 +54 @@
 
 #define CMD_OFFSET 0x0
-#define STS_OFFSET 0x4
-#define CFG_OFFSET 0x40
+#define CONFIGFLAG_OFFSET 0x40
 
 #define USBCMD_RUN 1
@@ -187 +186 @@
         CHECK_RET_HANGUP_RETURN(ret, "Failed(%d) to read PCI config space.\n",
             ret);
-        usb_log_info("Register space BAR at %p:%" PRIxn ".\n",
-            (void *) address, value);
+        usb_log_info("Register space BAR at %p:%" PRIxn ".\n", (void *) address, value);
 
         /* clear lower byte, it's not part of the BASE address */
@@ -265 +263 @@
          * It would prevent pre-OS code from interfering. */
         ret = async_req_3_0(parent_phone, DEV_IFACE_ID(PCI_DEV_IFACE),
-           IPC_M_CONFIG_SPACE_WRITE_32, eecp + USBLEGCTLSTS_OFFSET,
-           0xe0000000);
+           IPC_M_CONFIG_SPACE_WRITE_32, eecp + USBLEGCTLSTS_OFFSET, 0);
         CHECK_RET_HANGUP_RETURN(ret, "Failed(%d) zero USBLEGCTLSTS.\n", ret);
+        usb_log_debug("Zeroed USBLEGCTLSTS register.\n");
 
         /* Read again Legacy Support and Control register */
@@ -292 +290 @@
         volatile uint32_t *usbcmd =
             (uint32_t*)((uint8_t*)registers + operation_offset + CMD_OFFSET);
-        volatile uint32_t *usbsts =
-            (uint32_t*)((uint8_t*)registers + operation_offset + STS_OFFSET);
         volatile uint32_t *usbconfigured =
-            (uint32_t*)((uint8_t*)registers + operation_offset + CFG_OFFSET);
+            (uint32_t*)((uint8_t*)registers + operation_offset
+            + CONFIGFLAG_OFFSET);
         usb_log_debug("USBCMD value: %x.\n", *usbcmd);
         if (*usbcmd & USBCMD_RUN) {
                 *usbcmd = 0;
-                while (!(*usbsts & (1 << 12))); /*wait until hc is halted */
                 *usbconfigured = 0;
                 usb_log_info("EHCI turned off.\n");
@@ -305 +301 @@
                 usb_log_info("EHCI was not running.\n");
         }
-        usb_log_debug("Registers: %x(0x00080000):%x(0x00001000):%x(0x0).\n",
-            *usbcmd, *usbsts, *usbconfigured);
 
         async_hangup(parent_phone);