Changeset 41bfc64 in mainline for kernel/generic/src/proc/thread.c

Timestamp:

2024-01-20T17:24:56Z (12 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

7364e2d1

Parents:

3d84734

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-20 16:23:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-20 17:24:56)

Message:

Make thread→state weakly atomic so we don't need to hold thread lock

File:

• kernel/generic/src/proc/thread.c (modified) (8 diffs)

kernel/generic/src/proc/thread.c

@@ -209 +209 @@
 void thread_start(thread_t *thread)
 {
-        assert(thread->state == Entering);
+        assert(atomic_get_unordered(&thread->state) == Entering);
         thread_requeue_sleeping(thread_ref(thread));
 }
@@ -269 +269 @@
 
         thread->nomigrate = 0;
-        thread->state = Entering;
+        atomic_init(&thread->state, Entering);
 
         atomic_init(&thread->sleep_queue, NULL);
@@ -339 +339 @@
         irq_spinlock_unlock(&thread->task->lock, false);
 
-        assert((thread->state == Exiting) || (thread->state == Lingering));
+        assert((atomic_get_unordered(&thread->state) == Exiting) || (atomic_get_unordered(&thread->state) == Lingering));
 
         /* Clear cpu->fpu_owner if set to this thread. */
@@ -637 +637 @@
                 return EINVAL;
 
-        irq_spinlock_lock(&thread->lock, true);
-        state_t state = thread->state;
-        irq_spinlock_unlock(&thread->lock, true);
+        state_t state = atomic_get_unordered(&thread->state);
 
         errno_t rc = EOK;
@@ -686 +684 @@
         order_suffix(thread->ucycles, &ucycles, &usuffix);
         order_suffix(thread->kcycles, &kcycles, &ksuffix);
+
+        state_t state = atomic_get_unordered(&thread->state);
 
         char *name;
@@ -699 +699 @@
         else
                 printf("%-8" PRIu64 " %-14s %p %-8s %p %-5" PRIu32 "\n",
-                    thread->tid, name, thread, thread_states[thread->state],
+                    thread->tid, name, thread, thread_states[state],
                     thread->task, thread->task->container);
 
@@ -709 +709 @@
                         printf("none ");
 
-                if (thread->state == Sleeping) {
+                if (state == Sleeping) {
                         printf(" %p", thread->sleep_queue);
                 }
@@ -914 +914 @@
                 printf("Scheduling thread stack trace.\n");
                 thread->btrace = true;
-                if (thread->state == Sleeping)
+                if (atomic_get_unordered(&thread->state) == Sleeping)
                         sleeping = true;
         } else